Title: [152886] trunk/Source/WebCore
Revision
152886
Author
[email protected]
Date
2013-07-18 23:53:14 -0700 (Thu, 18 Jul 2013)

Log Message

Bindings generation tests are failing
https://bugs.webkit.org/show_bug.cgi?id=118877

Reviewed by Kentaro Hara.

I inadvertently removed the wrong part of the if statement
in r152845, causing hasAttribute() to be used unconditionally
for reflected boolean attributes instead of fastHasAttribute().
This patch fixes the issue.

No new tests, covered by bindings tests.

* bindings/scripts/CodeGenerator.pm:
(GetterExpression):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (152885 => 152886)


--- trunk/Source/WebCore/ChangeLog	2013-07-19 05:07:16 UTC (rev 152885)
+++ trunk/Source/WebCore/ChangeLog	2013-07-19 06:53:14 UTC (rev 152886)
@@ -1,3 +1,20 @@
+2013-07-18  Christophe Dumez  <[email protected]>
+
+        Bindings generation tests are failing
+        https://bugs.webkit.org/show_bug.cgi?id=118877
+
+        Reviewed by Kentaro Hara.
+
+        I inadvertently removed the wrong part of the if statement
+        in r152845, causing hasAttribute() to be used unconditionally
+        for reflected boolean attributes instead of fastHasAttribute().
+        This patch fixes the issue.
+
+        No new tests, covered by bindings tests.
+
+        * bindings/scripts/CodeGenerator.pm:
+        (GetterExpression):
+
 2013-07-18  Kwang Yul Seo  <[email protected]>
 
         WorkerGlobalScope should support onoffline/ononline event handlers

Modified: trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm (152885 => 152886)


--- trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm	2013-07-19 05:07:16 UTC (rev 152885)
+++ trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm	2013-07-19 06:53:14 UTC (rev 152886)
@@ -553,8 +553,7 @@
     if ($attribute->signature->extendedAttributes->{"URL"}) {
         $functionName = "getURLAttribute";
     } elsif ($attribute->signature->type eq "boolean") {
-        my $namespace = $generator->NamespaceForAttributeName($interfaceName, $contentAttributeName);
-        $functionName = "hasAttribute";
+        $functionName = "fastHasAttribute";
     } elsif ($attribute->signature->type eq "long") {
         $functionName = "getIntegralAttribute";
     } elsif ($attribute->signature->type eq "unsigned long") {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to