Diff
Modified: trunk/Source/WebCore/ChangeLog (152947 => 152948)
--- trunk/Source/WebCore/ChangeLog 2013-07-21 00:31:33 UTC (rev 152947)
+++ trunk/Source/WebCore/ChangeLog 2013-07-21 01:02:52 UTC (rev 152948)
@@ -1,3 +1,22 @@
+2013-07-20 Benjamin Poulain <[email protected]>
+
+ Add ASCIILiteral() on strings allocated often enough to appear in my Instruments
+ https://bugs.webkit.org/show_bug.cgi?id=118937
+
+ Reviewed by Alexey Proskuryakov.
+
+ * html/BaseCheckableInputType.cpp:
+ (WebCore::BaseCheckableInputType::saveFormControlState):
+ (WebCore::BaseCheckableInputType::fallbackValue):
+ * html/HTMLTextFormControlElement.cpp:
+ (WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
+ * inspector/InspectorApplicationCacheAgent.cpp:
+ (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
+ * loader/cache/CachedScript.cpp:
+ (WebCore::CachedScript::CachedScript):
+ * platform/network/ResourceRequestBase.h:
+ (WebCore::ResourceRequestBase::ResourceRequestBase):
+
2013-07-20 Dean Jackson <[email protected]>
Updated ANGLE is leaking like a sieve
Modified: trunk/Source/WebCore/html/BaseCheckableInputType.cpp (152947 => 152948)
--- trunk/Source/WebCore/html/BaseCheckableInputType.cpp 2013-07-21 00:31:33 UTC (rev 152947)
+++ trunk/Source/WebCore/html/BaseCheckableInputType.cpp 2013-07-21 01:02:52 UTC (rev 152948)
@@ -45,7 +45,7 @@
FormControlState BaseCheckableInputType::saveFormControlState() const
{
- return FormControlState(element()->checked() ? "on" : "off");
+ return FormControlState(element()->checked() ? ASCIILiteral("on") : ASCIILiteral("off"));
}
void BaseCheckableInputType::restoreFormControlState(const FormControlState& state)
@@ -94,7 +94,7 @@
String BaseCheckableInputType::fallbackValue() const
{
- return "on";
+ return ASCIILiteral("on");
}
bool BaseCheckableInputType::storesValueSeparateFromAttribute()
Modified: trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp (152947 => 152948)
--- trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp 2013-07-21 00:31:33 UTC (rev 152947)
+++ trunk/Source/WebCore/html/HTMLTextFormControlElement.cpp 2013-07-21 01:02:52 UTC (rev 152948)
@@ -166,7 +166,7 @@
HTMLElement* placeholder = placeholderElement();
if (!placeholder)
return;
- placeholder->setInlineStyleProperty(CSSPropertyVisibility, placeholderShouldBeVisible() ? "visible" : "hidden");
+ placeholder->setInlineStyleProperty(CSSPropertyVisibility, placeholderShouldBeVisible() ? ASCIILiteral("visible") : ASCIILiteral("hidden"));
}
void HTMLTextFormControlElement::fixPlaceholderRenderer(HTMLElement* placeholder, HTMLElement* siblingElement)
Modified: trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp (152947 => 152948)
--- trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp 2013-07-21 00:31:33 UTC (rev 152947)
+++ trunk/Source/WebCore/inspector/InspectorApplicationCacheAgent.cpp 2013-07-21 01:02:52 UTC (rev 152948)
@@ -50,7 +50,7 @@
}
InspectorApplicationCacheAgent::InspectorApplicationCacheAgent(InstrumentingAgents* instrumentingAgents, InspectorCompositeState* state, InspectorPageAgent* pageAgent)
- : InspectorBaseAgent<InspectorApplicationCacheAgent>("ApplicationCache", instrumentingAgents, state)
+ : InspectorBaseAgent<InspectorApplicationCacheAgent>(ASCIILiteral("ApplicationCache"), instrumentingAgents, state)
, m_pageAgent(pageAgent)
, m_frontend(0)
{
Modified: trunk/Source/WebCore/loader/cache/CachedScript.cpp (152947 => 152948)
--- trunk/Source/WebCore/loader/cache/CachedScript.cpp 2013-07-21 00:31:33 UTC (rev 152947)
+++ trunk/Source/WebCore/loader/cache/CachedScript.cpp 2013-07-21 01:02:52 UTC (rev 152948)
@@ -41,7 +41,7 @@
CachedScript::CachedScript(const ResourceRequest& resourceRequest, const String& charset)
: CachedResource(resourceRequest, Script)
- , m_decoder(TextResourceDecoder::create("application/_javascript_", charset))
+ , m_decoder(TextResourceDecoder::create(ASCIILiteral("application/_javascript_"), charset))
{
// It's _javascript_ we want.
// But some websites think their scripts are <some wrong mimetype here>
Modified: trunk/Source/WebCore/platform/network/ResourceRequestBase.h (152947 => 152948)
--- trunk/Source/WebCore/platform/network/ResourceRequestBase.h 2013-07-21 00:31:33 UTC (rev 152947)
+++ trunk/Source/WebCore/platform/network/ResourceRequestBase.h 2013-07-21 01:02:52 UTC (rev 152948)
@@ -162,7 +162,7 @@
: m_url(url)
, m_cachePolicy(policy)
, m_timeoutInterval(s_defaultTimeoutInterval)
- , m_httpMethod("GET")
+ , m_httpMethod(ASCIILiteral("GET"))
, m_allowCookies(true)
, m_resourceRequestUpdated(true)
, m_platformRequestUpdated(false)