Title: [152980] trunk/Source/WebCore
Revision
152980
Author
[email protected]
Date
2013-07-22 11:06:59 -0700 (Mon, 22 Jul 2013)

Log Message

[BlackBerry] Fix WebGL to a 2D canvas copies.
https://bugs.webkit.org/show_bug.cgi?id=118921
https://jira.bbqnx.net/browse/BRWSR-12714
JIRA 449577

Patch by Jakob Petsovits <[email protected]> on 2013-07-22
Reviewed by George Staikos.

The transform here was converted incorrectly when it
replaced the pixel copy that was there before.
As a true draw transformation, it doesn't need the "- 1"
modification that pixel copies often require.

Fixes existing webgl/conformance/canvas tests.

* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (152979 => 152980)


--- trunk/Source/WebCore/ChangeLog	2013-07-22 17:05:51 UTC (rev 152979)
+++ trunk/Source/WebCore/ChangeLog	2013-07-22 18:06:59 UTC (rev 152980)
@@ -1,3 +1,22 @@
+2013-07-22  Jakob Petsovits  <[email protected]>
+
+        [BlackBerry] Fix WebGL to a 2D canvas copies.
+        https://bugs.webkit.org/show_bug.cgi?id=118921
+        https://jira.bbqnx.net/browse/BRWSR-12714
+        JIRA 449577
+
+        Reviewed by George Staikos.
+
+        The transform here was converted incorrectly when it
+        replaced the pixel copy that was there before.
+        As a true draw transformation, it doesn't need the "- 1"
+        modification that pixel copies often require.
+
+        Fixes existing webgl/conformance/canvas tests.
+
+        * platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
+        (WebCore::GraphicsContext3D::paintToCanvas):
+
 2013-07-22  [email protected]  <[email protected]>
 
         [Curl] Download fails for certain urls.

Modified: trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp (152979 => 152980)


--- trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp	2013-07-22 17:05:51 UTC (rev 152979)
+++ trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp	2013-07-22 18:06:59 UTC (rev 152980)
@@ -365,7 +365,7 @@
     FloatRect src(0, 0, canvasWidth, canvasHeight);
     FloatRect dst(0, 0, imageWidth, imageHeight);
     double oldTransform[6];
-    double flipYTransform[6] = { 1.0f, 0.0f, 0.0f, -1.0f, 0.0f, imageHeight - 1 };
+    double flipYTransform[6] = { 1.0f, 0.0f, 0.0f, -1.0f, 0.0f, imageHeight };
     context->platformContext()->getTransform(oldTransform);
     context->platformContext()->setTransform(flipYTransform);
     BlackBerry::Platform::Graphics::TiledImage image(IntSize(imageWidth, imageHeight), reinterpret_cast_ptr<const unsigned*>(imagePixels));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to