Title: [152985] trunk/Source/WebCore
- Revision
- 152985
- Author
- [email protected]
- Date
- 2013-07-22 11:48:19 -0700 (Mon, 22 Jul 2013)
Log Message
[Old Web Inspector] When right-clicking on a DataGrid column, show editing menu option as "Edit <columnName>" instead of just "Edit"
https://bugs.webkit.org/show_bug.cgi?id=118971
Patch by Diego Pino Garcia <[email protected]> on 2013-07-22
Reviewed by Timothy Hatcher.
* English.lproj/localizedStrings.js:
* inspector/front-end/DataGrid.js: Change "Edit" for "Edit <columnTitle>"
(WebInspector.DataGrid.prototype._contextMenuInDataTable):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (152984 => 152985)
--- trunk/Source/WebCore/ChangeLog 2013-07-22 18:25:22 UTC (rev 152984)
+++ trunk/Source/WebCore/ChangeLog 2013-07-22 18:48:19 UTC (rev 152985)
@@ -1,3 +1,14 @@
+2013-07-22 Diego Pino Garcia <[email protected]>
+
+ [Old Web Inspector] When right-clicking on a DataGrid column, show editing menu option as "Edit <columnName>" instead of just "Edit"
+ https://bugs.webkit.org/show_bug.cgi?id=118971
+
+ Reviewed by Timothy Hatcher.
+
+ * English.lproj/localizedStrings.js:
+ * inspector/front-end/DataGrid.js: Change "Edit" for "Edit <columnTitle>"
+ (WebInspector.DataGrid.prototype._contextMenuInDataTable):
+
2013-07-22 Alex Christensen <[email protected]>
Added assembly files to Windows 64-bit builds.
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (152984 => 152985)
--- trunk/Source/WebCore/English.lproj/localizedStrings.js 2013-07-22 18:25:22 UTC (rev 152984)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js 2013-07-22 18:48:19 UTC (rev 152985)
@@ -180,6 +180,7 @@
localizedStrings["Edit text"] = "Edit text";
localizedStrings["Edit as HTML"] = "Edit as HTML";
localizedStrings["Edit"] = "Edit";
+localizedStrings["Edit “%s”"] = "Edit “%s”";
localizedStrings["Element state: %s"] = "Element state: %s";
localizedStrings["Elements Panel"] = "Elements Panel";
localizedStrings["Elements"] = "Elements";
Modified: trunk/Source/WebCore/inspector/front-end/DataGrid.js (152984 => 152985)
--- trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-07-22 18:25:22 UTC (rev 152984)
+++ trunk/Source/WebCore/inspector/front-end/DataGrid.js 2013-07-22 18:48:19 UTC (rev 152985)
@@ -931,14 +931,15 @@
contextMenu.appendItem(WebInspector.UIString("Refresh"), this._refreshCallback.bind(this));
if (gridNode && gridNode.selectable && !gridNode.isEventWithinDisclosureTriangle(event)) {
- // FIXME: Use the column names for Editing, instead of just "Edit".
if (this._editCallback) {
if (gridNode === this.creationNode)
contextMenu.appendItem(WebInspector.UIString(WebInspector.useLowerCaseMenuTitles() ? "Add new" : "Add New"), this._startEditing.bind(this, event.target));
else {
var columnIdentifier = this.columnIdentifierFromNode(event.target);
- if (columnIdentifier && this.columns[columnIdentifier].editable)
- contextMenu.appendItem(WebInspector.UIString("Edit"), this._startEditing.bind(this, event.target));
+ if (columnIdentifier && this.columns[columnIdentifier].editable) {
+ var columnTitle = columnIdentifier[0].toUpperCase() + columnIdentifier.slice(1);
+ contextMenu.appendItem(WebInspector.UIString("Edit “%s”", columnTitle), this._startEditing.bind(this, event.target));
+ }
}
}
if (this._deleteCallback && gridNode !== this.creationNode)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes