Title: [152989] trunk/Source/WebCore
- Revision
- 152989
- Author
- [email protected]
- Date
- 2013-07-22 13:54:46 -0700 (Mon, 22 Jul 2013)
Log Message
PlugIn content can disappear after restarting
https://bugs.webkit.org/show_bug.cgi?id=118982
Reviewed by Simon Fraser.
When a snapshotted plug-in is restarted, we inserted its compositing
layer back into the tree, but didn't recalculate style. This meant
that a subsequent compositing tree operation (such as any hardware
animation) could cause the content to disappear.
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::setDisplayState): Force a style recalc.
(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (152988 => 152989)
--- trunk/Source/WebCore/ChangeLog 2013-07-22 20:52:42 UTC (rev 152988)
+++ trunk/Source/WebCore/ChangeLog 2013-07-22 20:54:46 UTC (rev 152989)
@@ -1,3 +1,19 @@
+2013-07-22 Dean Jackson <[email protected]>
+
+ PlugIn content can disappear after restarting
+ https://bugs.webkit.org/show_bug.cgi?id=118982
+
+ Reviewed by Simon Fraser.
+
+ When a snapshotted plug-in is restarted, we inserted its compositing
+ layer back into the tree, but didn't recalculate style. This meant
+ that a subsequent compositing tree operation (such as any hardware
+ animation) could cause the content to disappear.
+
+ * html/HTMLPlugInImageElement.cpp:
+ (WebCore::HTMLPlugInImageElement::setDisplayState): Force a style recalc.
+ (WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired): Ditto.
+
2013-07-22 Zalan Bujtas <[email protected]>
REGRESSION(r152227) Images with compositing layer don't show up unless the containing window is resized.
Modified: trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp (152988 => 152989)
--- trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2013-07-22 20:52:42 UTC (rev 152988)
+++ trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp 2013-07-22 20:54:46 UTC (rev 152989)
@@ -130,6 +130,7 @@
if (state == RestartingWithPendingMouseClick || state == Restarting) {
m_isRestartedPlugin = true;
m_snapshotDecision = NeverSnapshot;
+ setNeedsStyleRecalc(SyntheticStyleChange);
if (displayState() == DisplayingSnapshot)
m_removeSnapshotTimer.startOneShot(removeSnapshotTimerDelay);
}
@@ -423,6 +424,7 @@
{
m_snapshotImage = nullptr;
m_isRestartedPlugin = false;
+ setNeedsStyleRecalc(SyntheticStyleChange);
if (renderer())
renderer()->repaint();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes