Title: [153084] trunk/Tools
- Revision
- 153084
- Author
- [email protected]
- Date
- 2013-07-24 07:53:31 -0700 (Wed, 24 Jul 2013)
Log Message
[GTK] [WK2] Handle wheel event with delta zero
https://bugs.webkit.org/show_bug.cgi?id=118973
Patch by Anton Obzhirov <[email protected]> on 2013-07-24
Reviewed by Gustavo Noronha Silva.
Added handling of zero mouse scroll deltas in EventSenderProxy similar
to WK1 and Qt/EFL ports.
fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
failing on WK2.
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::mouseScrollBy):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (153083 => 153084)
--- trunk/Tools/ChangeLog 2013-07-24 12:52:48 UTC (rev 153083)
+++ trunk/Tools/ChangeLog 2013-07-24 14:53:31 UTC (rev 153084)
@@ -1,3 +1,19 @@
+2013-07-24 Anton Obzhirov <[email protected]>
+
+ [GTK] [WK2] Handle wheel event with delta zero
+ https://bugs.webkit.org/show_bug.cgi?id=118973
+
+ Reviewed by Gustavo Noronha Silva.
+
+ Added handling of zero mouse scroll deltas in EventSenderProxy similar
+ to WK1 and Qt/EFL ports.
+
+ fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
+ failing on WK2.
+
+ * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
+ (WTR::EventSenderProxy::mouseScrollBy):
+
2013-07-23 Andreas Kling <[email protected]>
REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
Modified: trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp (153083 => 153084)
--- trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp 2013-07-24 12:52:48 UTC (rev 153083)
+++ trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp 2013-07-24 14:53:31 UTC (rev 153084)
@@ -377,6 +377,10 @@
void EventSenderProxy::mouseScrollBy(int horizontal, int vertical)
{
+ // Copy behaviour of Qt and EFL - just return in case of (0,0) mouse scroll
+ if (!horizontal && !vertical)
+ return;
+
GdkEvent* event = gdk_event_new(GDK_SCROLL);
event->scroll.x = m_position.x;
event->scroll.y = m_position.y;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
