Title: [153086] trunk/Source/WebCore
- Revision
- 153086
- Author
- [email protected]
- Date
- 2013-07-24 08:44:51 -0700 (Wed, 24 Jul 2013)
Log Message
WebVTTParser's identifier buffering can ignore subsequent lines
https://bugs.webkit.org/show_bug.cgi?id=118483
Patch by Brendan Long <[email protected]> on 2013-07-24
Reviewed by Eric Carlson.
No new tests since this bug can't be reproduced in layout tests.
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::parseBytes): Only buffer the identifier if we haven't read an entire line.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153085 => 153086)
--- trunk/Source/WebCore/ChangeLog 2013-07-24 15:27:25 UTC (rev 153085)
+++ trunk/Source/WebCore/ChangeLog 2013-07-24 15:44:51 UTC (rev 153086)
@@ -1,3 +1,15 @@
+2013-07-24 Brendan Long <[email protected]>
+
+ WebVTTParser's identifier buffering can ignore subsequent lines
+ https://bugs.webkit.org/show_bug.cgi?id=118483
+
+ Reviewed by Eric Carlson.
+
+ No new tests since this bug can't be reproduced in layout tests.
+
+ * html/track/WebVTTParser.cpp:
+ (WebCore::WebVTTParser::parseBytes): Only buffer the identifier if we haven't read an entire line.
+
2013-07-23 Andreas Kling <[email protected]>
REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
Modified: trunk/Source/WebCore/html/track/WebVTTParser.cpp (153085 => 153086)
--- trunk/Source/WebCore/html/track/WebVTTParser.cpp 2013-07-24 15:27:25 UTC (rev 153085)
+++ trunk/Source/WebCore/html/track/WebVTTParser.cpp 2013-07-24 15:44:51 UTC (rev 153086)
@@ -151,9 +151,9 @@
switch (m_state) {
case Initial:
- // Buffer up at least 9 bytes before proceeding with checking for the file identifier.
+ // Buffer up at least 9 bytes or a full line before proceeding with checking for the file identifier.
m_identifierData.append(data, length);
- if (m_identifierData.size() < bomLength + fileIdentifierLength)
+ if (position == line.sizeInBytes() && m_identifierData.size() < bomLength + fileIdentifierLength)
return;
// 4-12 - Collect the first line and check for "WEBVTT".
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
