Title: [153093] trunk
- Revision
- 153093
- Author
- [email protected]
- Date
- 2013-07-24 12:03:30 -0700 (Wed, 24 Jul 2013)
Log Message
Make KURL::hasPath private
https://bugs.webkit.org/show_bug.cgi?id=118279
Reviewed by Darin Adler.
Source/WebCore:
* platform/KURL.h: The KURL::hasPath method is not used outside of the KURL class, so it is made private.
Tools:
* TestWebKitAPI/Tests/WebCore/KURL.cpp:
(TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153092 => 153093)
--- trunk/Source/WebCore/ChangeLog 2013-07-24 18:33:16 UTC (rev 153092)
+++ trunk/Source/WebCore/ChangeLog 2013-07-24 19:03:30 UTC (rev 153093)
@@ -1,3 +1,12 @@
+2013-07-24 Zan Dobersek <[email protected]>
+
+ Make KURL::hasPath private
+ https://bugs.webkit.org/show_bug.cgi?id=118279
+
+ Reviewed by Darin Adler.
+
+ * platform/KURL.h: The KURL::hasPath method is not used outside of the KURL class, so it is made private.
+
2013-07-24 Jessie Berlin <[email protected]>
Remove WKPageGetPlugInInformation - it is not used anymore
Modified: trunk/Source/WebCore/platform/KURL.h (153092 => 153093)
--- trunk/Source/WebCore/platform/KURL.h 2013-07-24 18:33:16 UTC (rev 153092)
+++ trunk/Source/WebCore/platform/KURL.h 2013-07-24 19:03:30 UTC (rev 153093)
@@ -89,11 +89,6 @@
bool isEmpty() const;
bool isValid() const;
- // Returns true if this URL has a path. Note that "http://foo.com/" has a
- // path of "/", so this function will return true. Only invalid or
- // non-hierarchical (like "_javascript_:") URLs will have no path.
- bool hasPath() const;
-
// Returns true if you can set the host and port for the URL.
// Non-hierarchical URLs don't have a host and port.
bool canSetHostOrPort() const { return isHierarchical(); }
@@ -204,6 +199,8 @@
void parse(const String&);
void parse(const char* url, const String* originalString = 0);
+ bool hasPath() const;
+
String m_string;
bool m_isValid : 1;
bool m_protocolIsInHTTPFamily : 1;
Modified: trunk/Tools/ChangeLog (153092 => 153093)
--- trunk/Tools/ChangeLog 2013-07-24 18:33:16 UTC (rev 153092)
+++ trunk/Tools/ChangeLog 2013-07-24 19:03:30 UTC (rev 153093)
@@ -1,3 +1,13 @@
+2013-07-24 Zan Dobersek <[email protected]>
+
+ Make KURL::hasPath private
+ https://bugs.webkit.org/show_bug.cgi?id=118279
+
+ Reviewed by Darin Adler.
+
+ * TestWebKitAPI/Tests/WebCore/KURL.cpp:
+ (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
+
2013-07-24 Anton Obzhirov <[email protected]>
[GTK] TestInspectorServer unit test is timing out
Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/KURL.cpp (153092 => 153093)
--- trunk/Tools/TestWebKitAPI/Tests/WebCore/KURL.cpp 2013-07-24 18:33:16 UTC (rev 153092)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/KURL.cpp 2013-07-24 19:03:30 UTC (rev 153093)
@@ -44,7 +44,6 @@
{
KURL kurl;
- EXPECT_FALSE(kurl.hasPath());
EXPECT_TRUE(kurl.isEmpty());
EXPECT_TRUE(kurl.isNull());
EXPECT_FALSE(kurl.isValid());
@@ -54,7 +53,6 @@
{
KURL kurl(ParsedURLString, "http://username:[email protected]:8080/index.html?var=val#fragment");
- EXPECT_TRUE(kurl.hasPath());
EXPECT_FALSE(kurl.isEmpty());
EXPECT_FALSE(kurl.isNull());
EXPECT_TRUE(kurl.isValid());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
