Title: [153105] trunk/Source/WebCore
- Revision
- 153105
- Author
- [email protected]
- Date
- 2013-07-24 15:45:19 -0700 (Wed, 24 Jul 2013)
Log Message
REGRESSION (r152335): Mac Pro title occluded in MobileSafari; can't scroll page
https://bugs.webkit.org/show_bug.cgi?id=119066
<rdar://problem/14499184>
Reviewed by Daniel Bates.
Following <http://trac.webkit.org/changeset/152335> (bug #118337) we set
the z-index to 0 on every element with CSS "overflow: scroll" and
"-webkit-overflow-scrolling: touch" regardless of whether the element has
non-auto z-index. Instead we should only set the z-index to 0 for such elements
that have an auto z-index.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153104 => 153105)
--- trunk/Source/WebCore/ChangeLog 2013-07-24 21:58:36 UTC (rev 153104)
+++ trunk/Source/WebCore/ChangeLog 2013-07-24 22:45:19 UTC (rev 153105)
@@ -1,3 +1,20 @@
+2013-07-24 Simon Fraser <[email protected]>
+
+ REGRESSION (r152335): Mac Pro title occluded in MobileSafari; can't scroll page
+ https://bugs.webkit.org/show_bug.cgi?id=119066
+ <rdar://problem/14499184>
+
+ Reviewed by Daniel Bates.
+
+ Following <http://trac.webkit.org/changeset/152335> (bug #118337) we set
+ the z-index to 0 on every element with CSS "overflow: scroll" and
+ "-webkit-overflow-scrolling: touch" regardless of whether the element has
+ non-auto z-index. Instead we should only set the z-index to 0 for such elements
+ that have an auto z-index.
+
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::adjustRenderStyle):
+
2013-07-24 Ryosuke Niwa <[email protected]>
Use-after-free in ApplyStyleCommand::removeInlineStyle
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (153104 => 153105)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2013-07-24 21:58:36 UTC (rev 153104)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2013-07-24 22:45:19 UTC (rev 153105)
@@ -1492,7 +1492,7 @@
#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
// Touch overflow scrolling creates a stacking context.
- if (style->useTouchOverflowScrolling() && (isScrollableOverflow(style->overflowX()) || isScrollableOverflow(style->overflowY())))
+ if (style->hasAutoZIndex() && style->useTouchOverflowScrolling() && (isScrollableOverflow(style->overflowX()) || isScrollableOverflow(style->overflowY())))
style->setZIndex(0);
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
