Title: [153253] trunk/Source/_javascript_Core
Revision
153253
Author
[email protected]
Date
2013-07-24 21:03:59 -0700 (Wed, 24 Jul 2013)

Log Message

fourthTier: FTL::canCompile(Graph&) should not consider nodes that won't be compiled
https://bugs.webkit.org/show_bug.cgi?id=118097

Reviewed by Mark Hahnenberg.

This increases coverage to include programs that have unprofiled paths. Those paths will
often have nodes that appear to do untyped speculations, and the FTL sometimes doesn't
support those; except that it doesn't matter since the reason why they were untyped is
that they were unprofiled and anyway we won't run them because we'll exit before them.

* ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (153252 => 153253)


--- trunk/Source/_javascript_Core/ChangeLog	2013-07-25 04:03:57 UTC (rev 153252)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-07-25 04:03:59 UTC (rev 153253)
@@ -1,5 +1,20 @@
 2013-06-26  Filip Pizlo  <[email protected]>
 
+        fourthTier: FTL::canCompile(Graph&) should not consider nodes that won't be compiled
+        https://bugs.webkit.org/show_bug.cgi?id=118097
+
+        Reviewed by Mark Hahnenberg.
+        
+        This increases coverage to include programs that have unprofiled paths. Those paths will
+        often have nodes that appear to do untyped speculations, and the FTL sometimes doesn't
+        support those; except that it doesn't matter since the reason why they were untyped is
+        that they were unprofiled and anyway we won't run them because we'll exit before them.
+
+        * ftl/FTLCapabilities.cpp:
+        (JSC::FTL::canCompile):
+
+2013-06-26  Filip Pizlo  <[email protected]>
+
         fourthTier: FTL should support ArrayifyToStructure
         https://bugs.webkit.org/show_bug.cgi?id=118095
 

Modified: trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp (153252 => 153253)


--- trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp	2013-07-25 04:03:57 UTC (rev 153252)
+++ trunk/Source/_javascript_Core/ftl/FTLCapabilities.cpp	2013-07-25 04:03:59 UTC (rev 153253)
@@ -186,7 +186,11 @@
         if (!block)
             continue;
         
-        for (unsigned nodeIndex = block->size(); nodeIndex--;) {
+        // We don't care if we can compile blocks that the CFA hasn't visited.
+        if (!block->cfaHasVisited)
+            continue;
+        
+        for (unsigned nodeIndex = 0; nodeIndex < block->size(); ++nodeIndex) {
             Node* node = block->at(nodeIndex);
             
             for (unsigned childIndex = graph.numChildren(node); childIndex--;) {
@@ -225,6 +229,10 @@
                 }
                 return false;
             }
+            
+            // We don't care if we can compile anything after a force-exit.
+            if (node->op() == ForceOSRExit || node->op() == ForwardForceOSRExit)
+                break;
         }
     }
     
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to