[webkit-changes] [153370] trunk/Source/JavaScriptCore

[commit-queue]

Title: [153370] trunk/Source/_javascript_Core

Revision

153370

Author

commit-qu...@webkit.org

Date

2013-07-26 03:33:24 -0700 (Fri, 26 Jul 2013)

Log Message

REGRESSION(FTL): Crash in sh4 baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=119138

Patch by Julien Brianceau <jbrianc...@nds.com> on 2013-07-26
Reviewed by Csaba Osztrogonác.

This crash is due to incomplete report of r150146 and r148474.

* jit/JITStubsSH4.h:

Modified Paths

• trunk/Source/_javascript_Core/ChangeLog
• trunk/Source/_javascript_Core/jit/JITStubsSH4.h

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (153369 => 153370)

--- trunk/Source/_javascript_Core/ChangeLog	2013-07-26 08:34:32 UTC (rev 153369)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-07-26 10:33:24 UTC (rev 153370)
@@ -1,3 +1,14 @@
+2013-07-26  Julien Brianceau  <jbrianc...@nds.com>
+
+        REGRESSION(FTL): Crash in sh4 baseline JIT.
+        https://bugs.webkit.org/show_bug.cgi?id=119138
+
+        Reviewed by Csaba Osztrogonác.
+
+        This crash is due to incomplete report of r150146 and r148474.
+
+        * jit/JITStubsSH4.h:
+
 2013-07-26  Zan Dobersek  <zdober...@igalia.com>
 
         Unreviewed.

Modified: trunk/Source/_javascript_Core/jit/JITStubsSH4.h (153369 => 153370)

--- trunk/Source/_javascript_Core/jit/JITStubsSH4.h	2013-07-26 08:34:32 UTC (rev 153369)
+++ trunk/Source/_javascript_Core/jit/JITStubsSH4.h	2013-07-26 10:33:24 UTC (rev 153370)
@@ -52,8 +52,6 @@
     "mov.l r7, @-r15" "\n"
     "mov.l r6, @-r15" "\n"
     "mov.l r5, @-r15" "\n"
-    "mov.l r8, @-r15" "\n"
-    "mov #127, r8" "\n"
     "mov.l r14, @-r15" "\n"
     "sts.l pr, @-r15" "\n"
     "mov.l r13, @-r15" "\n"
@@ -69,10 +67,12 @@
     "mov.l @r15+,r13" "\n"
     "lds.l @r15+,pr" "\n"
     "mov.l @r15+,r14" "\n"
-    "mov.l @r15+,r8" "\n"
     "add #12, r15" "\n"
     "rts" "\n"
     "nop" "\n"
+".globl " SYMBOL_STRING(ctiTrampolineEnd) "\n"
+HIDE_SYMBOL(ctiTrampolineEnd) "\n"
+SYMBOL_STRING(ctiTrampolineEnd) ":" "\n"
 );
 
 asm volatile (
@@ -90,7 +90,6 @@
     "mov.l @r15+,r13" "\n"
     "lds.l @r15+,pr" "\n"
     "mov.l @r15+,r14" "\n"
-    "mov.l @r15+,r8" "\n"
     "add #12, r15" "\n"
     "rts" "\n"
     "nop" "\n"
@@ -114,7 +113,6 @@
     "mov.l @r15+,r13" "\n"
     "lds.l @r15+,pr" "\n"
     "mov.l @r15+,r14" "\n"
-    "mov.l @r15+,r8" "\n"
     "add #12, r15" "\n"
     "mov r0, r4" "\n"
     "jmp @r1" "\n"
@@ -133,7 +131,6 @@
     "mov.l @r15+,r13" "\n"
     "lds.l @r15+,pr" "\n"
     "mov.l @r15+,r14" "\n"
-    "mov.l @r15+,r8" "\n"
     "add #12, r15" "\n"
     "rts" "\n"
     "nop" "\n"

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes