Title: [153377] trunk/Source/WebCore
- Revision
- 153377
- Author
- [email protected]
- Date
- 2013-07-26 12:19:34 -0700 (Fri, 26 Jul 2013)
Log Message
[Windows] Remove workarounds now that rdar://problem/14390466 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=119150
Reviewed by Anders Carlsson.
* platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::createPlayer): Remove workaround to add legible output
after player is created.
(WebCore::AVFWrapper::createPlayerItem): Remove workaround to delay adding
legible output until player is created.
(WebCore::AVFWrapper::platformLayer): Get rid of unused temporary.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153376 => 153377)
--- trunk/Source/WebCore/ChangeLog 2013-07-26 19:06:32 UTC (rev 153376)
+++ trunk/Source/WebCore/ChangeLog 2013-07-26 19:19:34 UTC (rev 153377)
@@ -1,5 +1,19 @@
2013-07-26 Brent Fulgham <[email protected]>
+ [Windows] Remove workarounds now that rdar://problem/14390466 is fixed.
+ https://bugs.webkit.org/show_bug.cgi?id=119150
+
+ Reviewed by Anders Carlsson.
+
+ * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
+ (WebCore::AVFWrapper::createPlayer): Remove workaround to add legible output
+ after player is created.
+ (WebCore::AVFWrapper::createPlayerItem): Remove workaround to delay adding
+ legible output until player is created.
+ (WebCore::AVFWrapper::platformLayer): Get rid of unused temporary.
+
+2013-07-26 Brent Fulgham <[email protected]>
+
[Windows] Unreviewed gardening.
* WebCore.vcxproj/WebCore.vcxproj: Add missing header file to ease code viewing.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp (153376 => 153377)
--- trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp 2013-07-26 19:06:32 UTC (rev 153376)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp 2013-07-26 19:19:34 UTC (rev 153377)
@@ -1271,13 +1271,6 @@
if (m_d3dDevice && AVCFPlayerSetDirect3DDevicePtr())
AVCFPlayerSetDirect3DDevicePtr()(playerRef, m_d3dDevice.get());
-#if HAVE(AVFOUNDATION_MEDIA_SELECTION_GROUP) && HAVE(AVFOUNDATION_LEGIBLE_OUTPUT_SUPPORT)
- // Because of a bug in AVFoundationCF, we have to wait until the player is created before we can add the legible output:
- // Once <rdar://problem/14390466> this is fixed, we can remove the following two lines.
- ::Sleep(1000); // FIXME: This is being fixed as part of <rdar://problem/14390466>
- AVCFPlayerItemAddOutput(avPlayerItem(), legibleOutput());
-#endif
-
CFNotificationCenterRef center = CFNotificationCenterGetLocalCenter();
ASSERT(center);
@@ -1328,9 +1321,7 @@
AVCFPlayerItemLegibleOutputSetCallbacks(m_legibleOutput.get(), &callbackInfo, dispatch_get_main_queue());
AVCFPlayerItemLegibleOutputSetAdvanceIntervalForCallbackInvocation(m_legibleOutput.get(), legibleOutputAdvanceInterval);
AVCFPlayerItemLegibleOutputSetTextStylingResolution(m_legibleOutput.get(), AVCFPlayerItemLegibleOutputTextStylingResolutionSourceAndRulesOnly);
- // We cannot add the Legible Output to the player item until the player is constructed. <rdar://problem/14390466>
- // Once this is fixed, we can uncomment the following line.
- // AVCFPlayerItemAddOutput(m_avPlayerItem.get(), m_legibleOutput.get());
+ AVCFPlayerItemAddOutput(m_avPlayerItem.get(), m_legibleOutput.get());
#endif
}
@@ -1539,8 +1530,7 @@
if (!m_videoLayerWrapper)
return 0;
- CACFLayerRef layerRef = AVCFPlayerLayerCopyCACFLayer(m_avCFVideoLayer.get());
- m_caVideoLayer = adoptCF(layerRef);
+ m_caVideoLayer = adoptCF(AVCFPlayerLayerCopyCACFLayer(m_avCFVideoLayer.get()));
CACFLayerInsertSublayer(m_videoLayerWrapper->platformLayer(), m_caVideoLayer.get(), 0);
m_videoLayerWrapper->setAnchorPoint(FloatPoint3D());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
