Title: [153418] trunk/Source/WebCore
Revision
153418
Author
[email protected]
Date
2013-07-28 23:23:55 -0700 (Sun, 28 Jul 2013)

Log Message

Don't update the text track override CSS every time a media element is created.
<http://webkit.org/b/119199>
<rdar://problem/14572855>

Reviewed by Darin Adler.

We should only have to update the CSS if the accessibility caption preferences are changed.
This was forcing a full style recalc in every Document any time a media element is instantiated.

* page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (153417 => 153418)


--- trunk/Source/WebCore/ChangeLog	2013-07-29 04:37:24 UTC (rev 153417)
+++ trunk/Source/WebCore/ChangeLog	2013-07-29 06:23:55 UTC (rev 153418)
@@ -1,3 +1,17 @@
+2013-07-28  Andreas Kling  <[email protected]>
+
+        Don't update the text track override CSS every time a media element is created.
+        <http://webkit.org/b/119199>
+        <rdar://problem/14572855>
+
+        Reviewed by Darin Adler.
+
+        We should only have to update the CSS if the accessibility caption preferences are changed.
+        This was forcing a full style recalc in every Document any time a media element is instantiated.
+
+        * page/CaptionUserPreferencesMediaAF.cpp:
+        (WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges):
+
 2013-07-28  Andy Estes  <[email protected]>
 
         Stop exporting Widget::frameRectsChanged()

Modified: trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp (153417 => 153418)


--- trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp	2013-07-29 04:37:24 UTC (rev 153417)
+++ trunk/Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp	2013-07-29 06:23:55 UTC (rev 153418)
@@ -235,9 +235,8 @@
     if (!m_listeningForPreferenceChanges) {
         m_listeningForPreferenceChanges = true;
         CFNotificationCenterAddObserver(CFNotificationCenterGetLocalCenter(), this, userCaptionPreferencesChangedNotificationCallback, kMAXCaptionAppearanceSettingsChangedNotification, 0, CFNotificationSuspensionBehaviorCoalesce);
+        updateCaptionStyleSheetOveride();
     }
-    
-    updateCaptionStyleSheetOveride();
 }
 
 void CaptionUserPreferencesMediaAF::captionPreferencesChanged()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to