Title: [153497] trunk/Source/_javascript_Core
- Revision
- 153497
- Author
- [email protected]
- Date
- 2013-07-30 15:12:25 -0700 (Tue, 30 Jul 2013)
Log Message
Add an assertion to SpeculateCellOperand
https://bugs.webkit.org/show_bug.cgi?id=119276
Reviewed by Michael Saboff.
More assertions are better
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (153496 => 153497)
--- trunk/Source/_javascript_Core/ChangeLog 2013-07-30 22:01:25 UTC (rev 153496)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-07-30 22:12:25 UTC (rev 153497)
@@ -1,3 +1,16 @@
+2013-07-30 Oliver Hunt <[email protected]>
+
+ Add an assertion to SpeculateCellOperand
+ https://bugs.webkit.org/show_bug.cgi?id=119276
+
+ Reviewed by Michael Saboff.
+
+ More assertions are better
+
+ * dfg/DFGSpeculativeJIT64.cpp:
+ (JSC::DFG::SpeculativeJIT::fillSpeculateCell):
+ (JSC::DFG::SpeculativeJIT::compile):
+
2013-07-30 Mark Lam <[email protected]>
Fix problems with divot and lineStart mismatches.
Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp (153496 => 153497)
--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2013-07-30 22:01:25 UTC (rev 153496)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp 2013-07-30 22:12:25 UTC (rev 153497)
@@ -1168,6 +1168,11 @@
case DataFormatJSCell: {
GPRReg gpr = info.gpr();
m_gprs.lock(gpr);
+#if DFG_ENABLE(JIT_ASSERT)
+ MacroAssembler::Jump checkCell = m_jit.branchTest64(MacroAssembler::Zero, gpr, GPRInfo::tagMaskRegister);
+ m_jit.breakpoint();
+ checkCell.link(&m_jit);
+#endif
return gpr;
}
@@ -3597,7 +3602,7 @@
GPRResult result(this);
callOperation(operationToThis, result.gpr(), thisValueGPR);
-
+
cellResult(result.gpr(), node);
break;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
