Title: [153507] trunk/Source/WebCore
Revision
153507
Author
[email protected]
Date
2013-07-30 18:50:16 -0700 (Tue, 30 Jul 2013)

Log Message

Don't post accessibility notification on object in detached document.
https://bugs.webkit.org/show_bug.cgi?id=119286

Reviewed by Ryosuke Niwa.

Merge https://chromium.googlesource.com/chromium/blink/+/ef9fc9e70202dcf33e5cf2f0f0a2135945ffe17e%5E%21/#F0

Don't post accessibility notification on object in detached document.

This can happen if an accessibility notification is queued on a node,
then that node is reparented to a different document that's not attached
anywhere before the accessibility notification is fired.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::notificationPostTimerFired):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (153506 => 153507)


--- trunk/Source/WebCore/ChangeLog	2013-07-31 01:18:22 UTC (rev 153506)
+++ trunk/Source/WebCore/ChangeLog	2013-07-31 01:50:16 UTC (rev 153507)
@@ -1,3 +1,21 @@
+2013-07-30  Chris Fleizach  <[email protected]>
+
+        Don't post accessibility notification on object in detached document.
+        https://bugs.webkit.org/show_bug.cgi?id=119286
+
+        Reviewed by Ryosuke Niwa.
+
+        Merge https://chromium.googlesource.com/chromium/blink/+/ef9fc9e70202dcf33e5cf2f0f0a2135945ffe17e%5E%21/#F0
+
+        Don't post accessibility notification on object in detached document.
+
+        This can happen if an accessibility notification is queued on a node,
+        then that node is reparented to a different document that's not attached
+        anywhere before the accessibility notification is fired.
+
+        * accessibility/AXObjectCache.cpp:
+        (WebCore::AXObjectCache::notificationPostTimerFired):
+
 2013-07-30  Andy Estes  <[email protected]>  
 
         Content filter replacement data uses the encoding from the blocked page's response headers

Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (153506 => 153507)


--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2013-07-31 01:18:22 UTC (rev 153506)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2013-07-31 01:50:16 UTC (rev 153507)
@@ -640,6 +640,9 @@
         if (!obj->axObjectID())
             continue;
 
+        if (!obj->axObjectCache())
+            continue;
+        
 #ifndef NDEBUG
         // Make sure none of the render views are in the process of being layed out.
         // Notifications should only be sent after the renderer has finished
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to