Title: [153512] trunk/Source/WebCore
- Revision
- 153512
- Author
- [email protected]
- Date
- 2013-07-31 00:23:41 -0700 (Wed, 31 Jul 2013)
Log Message
findFirstGrammarDetail doesn't need to be exposed.
https://bugs.webkit.org/show_bug.cgi?id=119249
Reviewed by Darin Adler.
Make TextCheckingHelper::findFirstGrammarDetail private.
Remove badGrammarPhraseLength param. It's not used any longer.
No new tests, no behavior change.
* editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
* editing/TextCheckingHelper.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153511 => 153512)
--- trunk/Source/WebCore/ChangeLog 2013-07-31 05:57:28 UTC (rev 153511)
+++ trunk/Source/WebCore/ChangeLog 2013-07-31 07:23:41 UTC (rev 153512)
@@ -1,3 +1,20 @@
+2013-07-30 Grzegorz Czajkowski <[email protected]>
+
+ findFirstGrammarDetail doesn't need to be exposed.
+ https://bugs.webkit.org/show_bug.cgi?id=119249
+
+ Reviewed by Darin Adler.
+
+ Make TextCheckingHelper::findFirstGrammarDetail private.
+ Remove badGrammarPhraseLength param. It's not used any longer.
+
+ No new tests, no behavior change.
+
+ * editing/TextCheckingHelper.cpp:
+ (WebCore::TextCheckingHelper::findFirstGrammarDetail):
+ (WebCore::TextCheckingHelper::findFirstBadGrammar):
+ * editing/TextCheckingHelper.h:
+
2013-07-30 Tim Horton <[email protected]>
DHTML drag can result in a null-deref under WebDragClient::startDrag
Modified: trunk/Source/WebCore/editing/TextCheckingHelper.cpp (153511 => 153512)
--- trunk/Source/WebCore/editing/TextCheckingHelper.cpp 2013-07-31 05:57:28 UTC (rev 153511)
+++ trunk/Source/WebCore/editing/TextCheckingHelper.cpp 2013-07-31 07:23:41 UTC (rev 153512)
@@ -415,7 +415,7 @@
}
#if USE(GRAMMAR_CHECKING)
-int TextCheckingHelper::findFirstGrammarDetail(const Vector<GrammarDetail>& grammarDetails, int badGrammarPhraseLocation, int /*badGrammarPhraseLength*/, int startOffset, int endOffset, bool markAll)
+int TextCheckingHelper::findFirstGrammarDetail(const Vector<GrammarDetail>& grammarDetails, int badGrammarPhraseLocation, int startOffset, int endOffset, bool markAll)
{
// Found some bad grammar. Find the earliest detail range that starts in our search range (if any).
// Optionally add a DocumentMarker for each detail in the range.
@@ -484,7 +484,7 @@
// Found some bad grammar. Find the earliest detail range that starts in our search range (if any).
- int badGrammarIndex = findFirstGrammarDetail(grammarDetails, badGrammarPhraseLocation, badGrammarPhraseLength, paragraph.checkingStart(), paragraph.checkingEnd(), markAll);
+ int badGrammarIndex = findFirstGrammarDetail(grammarDetails, badGrammarPhraseLocation, paragraph.checkingStart(), paragraph.checkingEnd(), markAll);
if (badGrammarIndex >= 0) {
ASSERT(static_cast<unsigned>(badGrammarIndex) < grammarDetails.size());
outGrammarDetail = grammarDetails[badGrammarIndex];
Modified: trunk/Source/WebCore/editing/TextCheckingHelper.h (153511 => 153512)
--- trunk/Source/WebCore/editing/TextCheckingHelper.h 2013-07-31 05:57:28 UTC (rev 153511)
+++ trunk/Source/WebCore/editing/TextCheckingHelper.h 2013-07-31 07:23:41 UTC (rev 153512)
@@ -88,16 +88,19 @@
void markAllMisspellings(RefPtr<Range>& firstMisspellingRange);
#if USE(GRAMMAR_CHECKING)
String findFirstBadGrammar(GrammarDetail& outGrammarDetail, int& outGrammarPhraseOffset, bool markAll);
- int findFirstGrammarDetail(const Vector<GrammarDetail>& grammarDetails, int badGrammarPhraseLocation, int badGrammarPhraseLength, int startOffset, int endOffset, bool markAll);
void markAllBadGrammar();
bool isUngrammatical(Vector<String>& guessesVector) const;
#endif
Vector<String> guessesForMisspelledOrUngrammaticalRange(bool checkGrammar, bool& misspelled, bool& ungrammatical) const;
+
private:
EditorClient* m_client;
RefPtr<Range> m_range;
bool unifiedTextCheckerEnabled() const;
+#if USE(GRAMMAR_CHECKING)
+ int findFirstGrammarDetail(const Vector<GrammarDetail>&, int badGrammarPhraseLocation, int startOffset, int endOffset, bool markAll);
+#endif
};
void checkTextOfParagraph(TextCheckerClient*, const UChar* text, int length,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
