Modified: trunk/Source/WebCore/ChangeLog (153522 => 153523)
--- trunk/Source/WebCore/ChangeLog 2013-07-31 14:39:38 UTC (rev 153522)
+++ trunk/Source/WebCore/ChangeLog 2013-07-31 16:08:00 UTC (rev 153523)
@@ -1,3 +1,17 @@
+2013-07-31 Jae Hyun Park <[email protected]>
+
+ [Coordinated Graphics] Use m_ prefix only for member variable
+ https://bugs.webkit.org/show_bug.cgi?id=119250
+
+ Reviewed by Noam Rosenthal.
+
+ WebKit coding style suggests to use m_ prefix only for data members.
+ This patch also removes unnecessary copy by passing const-reference
+ parameter values.
+
+ * platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h:
+ (WebCore::CoordinatedCustomFilterProgram::create):
+
2013-07-31 Allan Sandfeld Jensen <[email protected]>
[Qt] Images are down-scaled badly
Modified: trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h (153522 => 153523)
--- trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h 2013-07-31 14:39:38 UTC (rev 153522)
+++ trunk/Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h 2013-07-31 16:08:00 UTC (rev 153523)
@@ -34,9 +34,9 @@
class CoordinatedCustomFilterProgram : public CustomFilterProgram {
public:
- static PassRefPtr<CoordinatedCustomFilterProgram> create(String vertexShaderString, String m_fragmentShaderString, CustomFilterProgramType programType, CustomFilterProgramMixSettings mixSettings, CustomFilterMeshType meshType)
+ static PassRefPtr<CoordinatedCustomFilterProgram> create(const String& vertexShaderString, const String& fragmentShaderString, CustomFilterProgramType programType, const CustomFilterProgramMixSettings& mixSettings, CustomFilterMeshType meshType)
{
- return adoptRef(new CoordinatedCustomFilterProgram(vertexShaderString, m_fragmentShaderString, programType, mixSettings, meshType));
+ return adoptRef(new CoordinatedCustomFilterProgram(vertexShaderString, fragmentShaderString, programType, mixSettings, meshType));
}
virtual bool isLoaded() const OVERRIDE { return true; }
@@ -49,7 +49,7 @@
virtual void didRemoveLastClient() OVERRIDE { }
private:
- CoordinatedCustomFilterProgram(String vertexShaderString, String fragmentShaderString, CustomFilterProgramType programType, CustomFilterProgramMixSettings mixSettings, CustomFilterMeshType meshType)
+ CoordinatedCustomFilterProgram(const String& vertexShaderString, const String& fragmentShaderString, CustomFilterProgramType programType, const CustomFilterProgramMixSettings& mixSettings, CustomFilterMeshType meshType)
: CustomFilterProgram(programType, mixSettings, meshType)
, m_vertexShaderString(vertexShaderString)
, m_fragmentShaderString(fragmentShaderString)
