Title: [153536] trunk/LayoutTests
- Revision
- 153536
- Author
- [email protected]
- Date
- 2013-07-31 12:27:44 -0700 (Wed, 31 Jul 2013)
Log Message
RenderEmbeddedObject::isReplacementObscured is wrong if an obscuring element has pointer-events: none set
https://bugs.webkit.org/show_bug.cgi?id=119348
Reviewed by Dean Jackson.
Change the expected outcome of the test to want a visually-obscured
but clickable embed (because the obscuring element has pointer-events: none)
to be considered obscured.
Also, adjust the test so that it runs all of the subtests even if
some of them fail.
* plugins/unavailable-plugin-indicator-obscurity-expected.txt:
* plugins/unavailable-plugin-indicator-obscurity.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (153535 => 153536)
--- trunk/LayoutTests/ChangeLog 2013-07-31 19:26:22 UTC (rev 153535)
+++ trunk/LayoutTests/ChangeLog 2013-07-31 19:27:44 UTC (rev 153536)
@@ -1,3 +1,20 @@
+2013-07-31 Tim Horton <[email protected]>
+
+ RenderEmbeddedObject::isReplacementObscured is wrong if an obscuring element has pointer-events: none set
+ https://bugs.webkit.org/show_bug.cgi?id=119348
+
+ Reviewed by Dean Jackson.
+
+ Change the expected outcome of the test to want a visually-obscured
+ but clickable embed (because the obscuring element has pointer-events: none)
+ to be considered obscured.
+
+ Also, adjust the test so that it runs all of the subtests even if
+ some of them fail.
+
+ * plugins/unavailable-plugin-indicator-obscurity-expected.txt:
+ * plugins/unavailable-plugin-indicator-obscurity.html:
+
2013-07-23 Roger Fong <[email protected]>
Unreviewed gardening. AppleWin port.
Modified: trunk/LayoutTests/plugins/unavailable-plugin-indicator-obscurity-expected.txt (153535 => 153536)
--- trunk/LayoutTests/plugins/unavailable-plugin-indicator-obscurity-expected.txt 2013-07-31 19:26:22 UTC (rev 153535)
+++ trunk/LayoutTests/plugins/unavailable-plugin-indicator-obscurity-expected.txt 2013-07-31 19:27:44 UTC (rev 153536)
@@ -9,6 +9,7 @@
'visibilityHiddenOnParent' was obscured: true (expected true; PASS)
'pointerEventsBlocked' was obscured: true (expected true; PASS)
'pointerEventsBlockedOnParent' was obscured: true (expected true; PASS)
+'pointerEventsBlockedOnObscuringSibling' was obscured: false (expected true; FAIL)
'leftHalfObscured' was obscured: true (expected true; PASS)
'rightHalfObscured' was obscured: true (expected true; PASS)
'topHalfObscured' was obscured: true (expected true; PASS)
@@ -22,9 +23,8 @@
'large' was obscured: false (expected false; PASS)
'stackedHighOpacityParents' was obscured: false (expected false; PASS)
'notClippedByParent' was obscured: false (expected false; PASS)
-'pointerEventsBlockedOnObscuringSibling' was obscured: false (expected false; PASS)
'topQuarterObscured' was obscured: false (expected false; PASS)
'bottomQuarterObscured' was obscured: false (expected false; PASS)
-Passed all tests: true
+Passed all tests: false
Modified: trunk/LayoutTests/plugins/unavailable-plugin-indicator-obscurity.html (153535 => 153536)
--- trunk/LayoutTests/plugins/unavailable-plugin-indicator-obscurity.html 2013-07-31 19:26:22 UTC (rev 153535)
+++ trunk/LayoutTests/plugins/unavailable-plugin-indicator-obscurity.html 2013-07-31 19:27:44 UTC (rev 153536)
@@ -37,12 +37,12 @@
setTimeout(function () {
log("Expected to be obscured:");
- var failedAnyTest = testObscuredPlugins("shouldBeObscured", true);
+ var failedAnyExpectedObscuredTest = testObscuredPlugins("shouldBeObscured", true);
log("")
log("Expected to not be obscured:");
- failedAnyTest = failedAnyTest || testObscuredPlugins("shouldNotBeObscured", false);
+ var failedAnyExpectedVisibleTest = testObscuredPlugins("shouldNotBeObscured", false);
log("");
- log("Passed all tests: " + !failedAnyTest);
+ log("Passed all tests: " + !(failedAnyExpectedVisibleTest || failedAnyExpectedObscuredTest));
// Remove the plugins so that we don't have tons of whitespace in the output.
while(document.body.firstChild && document.body.firstChild.id != "log") {
@@ -116,7 +116,7 @@
<embed id="pointerEventsBlockedOnParent" class="shouldBeObscured" type="application/x-webkit-test-netscape"></embed>
</div>
<div class="container">
- <embed id="pointerEventsBlockedOnObscuringSibling" class="shouldNotBeObscured" type="application/x-webkit-test-netscape"></embed>
+ <embed id="pointerEventsBlockedOnObscuringSibling" class="shouldBeObscured" type="application/x-webkit-test-netscape"></embed>
<div class="cover" style="pointer-events: none;"></div>
</div>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
