Title: [153555] trunk/LayoutTests
- Revision
- 153555
- Author
- [email protected]
- Date
- 2013-07-31 18:08:47 -0700 (Wed, 31 Jul 2013)
Log Message
Clobbering window.console is not cool
https://bugs.webkit.org/show_bug.cgi?id=119364
Reviewed by Tim Horton.
full-screen-test.js overrides window.console, which is hella
confusing if you're trying to use console.log to debug a fullscreen test.
* fullscreen/full-screen-test.js:
(logConsole):
* fullscreen/resources/not-allowed.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (153554 => 153555)
--- trunk/LayoutTests/ChangeLog 2013-08-01 00:57:36 UTC (rev 153554)
+++ trunk/LayoutTests/ChangeLog 2013-08-01 01:08:47 UTC (rev 153555)
@@ -1,3 +1,17 @@
+2013-07-31 Simon Fraser <[email protected]>
+
+ Clobbering window.console is not cool
+ https://bugs.webkit.org/show_bug.cgi?id=119364
+
+ Reviewed by Tim Horton.
+
+ full-screen-test.js overrides window.console, which is hella
+ confusing if you're trying to use console.log to debug a fullscreen test.
+
+ * fullscreen/full-screen-test.js:
+ (logConsole):
+ * fullscreen/resources/not-allowed.html:
+
2013-07-31 Mark Lam <[email protected]>
Gardening: changing expectation for fast/forms/color/input-color-onchange-event.html
Modified: trunk/LayoutTests/fullscreen/full-screen-test.js (153554 => 153555)
--- trunk/LayoutTests/fullscreen/full-screen-test.js 2013-08-01 00:57:36 UTC (rev 153554)
+++ trunk/LayoutTests/fullscreen/full-screen-test.js 2013-08-01 01:08:47 UTC (rev 153555)
@@ -1,4 +1,4 @@
-var console = null;
+var consoleDiv = null;
var printFullTestDetails = true; // This is optionaly switched of by test whose tested values can differ. (see disableFullTestDetailsPrinting())
var runPixelTests;
@@ -31,11 +31,11 @@
function logConsole()
{
- if (!console && document.body) {
- console = document.createElement('div');
- document.body.appendChild(console);
+ if (!consoleDiv && document.body) {
+ consoleDiv = document.createElement('div');
+ document.body.appendChild(consoleDiv);
}
- return console;
+ return consoleDiv;
}
function testAndEnd(testFuncString)
Modified: trunk/LayoutTests/fullscreen/resources/not-allowed.html (153554 => 153555)
--- trunk/LayoutTests/fullscreen/resources/not-allowed.html 2013-08-01 00:57:36 UTC (rev 153554)
+++ trunk/LayoutTests/fullscreen/resources/not-allowed.html 2013-08-01 01:08:47 UTC (rev 153555)
@@ -3,5 +3,5 @@
<p>To test manually, click the "Go full screen" button - the page should not enter full screen mode.</p>
<div id="console"></div>
<script>
- top.console = document.getElementById('console');
+ top.consoleDiv = document.getElementById('console');
</script>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
