Title: [153568] trunk/LayoutTests
Revision
153568
Author
[email protected]
Date
2013-07-31 21:06:56 -0700 (Wed, 31 Jul 2013)

Log Message

Clobbering window.console is not cool because it makes debugging tests
harder.

* media/video-test.js:
(logConsole):

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (153567 => 153568)


--- trunk/LayoutTests/ChangeLog	2013-08-01 03:43:18 UTC (rev 153567)
+++ trunk/LayoutTests/ChangeLog	2013-08-01 04:06:56 UTC (rev 153568)
@@ -1,5 +1,13 @@
 2013-07-31  Simon Fraser  <[email protected]>
 
+        Clobbering window.console is not cool because it makes debugging tests
+        harder.
+
+        * media/video-test.js:
+        (logConsole):
+
+2013-07-31  Simon Fraser  <[email protected]>
+
         r153462 erroneously unskipped http/tests/multipart/invalid-image-data-standalone.html
         so put it back.
 

Modified: trunk/LayoutTests/media/video-test.js (153567 => 153568)


--- trunk/LayoutTests/media/video-test.js	2013-08-01 03:43:18 UTC (rev 153567)
+++ trunk/LayoutTests/media/video-test.js	2013-08-01 04:06:56 UTC (rev 153568)
@@ -1,7 +1,7 @@
 
 var video = null;
 var mediaElement = document; // If not set, an event from any element will trigger a waitForEvent() callback.
-var console = null;
+var consoleElement = null;
 var printFullTestDetails = true; // This is optionaly switched of by test whose tested values can differ. (see disableFullTestDetailsPrinting())
 var Failed = false;
 
@@ -33,11 +33,11 @@
 
 function logConsole()
 {
-    if (!console && document.body) {
-        console = document.createElement('div');
-        document.body.appendChild(console);
+    if (!consoleElement && document.body) {
+        consoleElement = document.createElement('div');
+        document.body.appendChild(consoleElement);
     }
-    return console;
+    return consoleElement;
 }
 
 function findMediaElement()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to