Title: [153632] trunk/Source/WebCore
- Revision
- 153632
- Author
- [email protected]
- Date
- 2013-08-01 18:57:12 -0700 (Thu, 01 Aug 2013)
Log Message
FormAssociatedElement shouldn't create out-of-tree FormAttributeTargetObserver
https://bugs.webkit.org/show_bug.cgi?id=119309
Reviewed by Kent Tamura.
Merge https://chromium.googlesource.com/chromium/blink/+/6fbdcbf311de539107bc28711b3f7a527176e97b.
I'm not merging the test since the attached test case only works when the shadow DOM API is enabled.
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore::FormAssociatedElement::resetFormAttributeTargetObserver):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153631 => 153632)
--- trunk/Source/WebCore/ChangeLog 2013-08-02 01:00:10 UTC (rev 153631)
+++ trunk/Source/WebCore/ChangeLog 2013-08-02 01:57:12 UTC (rev 153632)
@@ -1,3 +1,18 @@
+2013-07-31 Ryosuke Niwa <[email protected]>
+
+ FormAssociatedElement shouldn't create out-of-tree FormAttributeTargetObserver
+ https://bugs.webkit.org/show_bug.cgi?id=119309
+
+ Reviewed by Kent Tamura.
+
+ Merge https://chromium.googlesource.com/chromium/blink/+/6fbdcbf311de539107bc28711b3f7a527176e97b.
+
+ I'm not merging the test since the attached test case only works when the shadow DOM API is enabled.
+
+ * html/FormAssociatedElement.cpp:
+ (WebCore::FormAssociatedElement::formAttributeChanged):
+ (WebCore::FormAssociatedElement::resetFormAttributeTargetObserver):
+
2013-08-01 Rob Buis <[email protected]>
selectors should match attribute name with case sensitivity based on element & document type
Modified: trunk/Source/WebCore/html/FormAssociatedElement.cpp (153631 => 153632)
--- trunk/Source/WebCore/html/FormAssociatedElement.cpp 2013-08-02 01:00:10 UTC (rev 153631)
+++ trunk/Source/WebCore/html/FormAssociatedElement.cpp 2013-08-02 01:57:12 UTC (rev 153632)
@@ -179,7 +179,8 @@
m_formAttributeTargetObserver = nullptr;
} else {
resetFormOwner();
- resetFormAttributeTargetObserver();
+ if (element->inDocument())
+ resetFormAttributeTargetObserver();
}
}
@@ -253,6 +254,7 @@
void FormAssociatedElement::resetFormAttributeTargetObserver()
{
+ ASSERT(toHTMLElement(this)->inDocument());
m_formAttributeTargetObserver = FormAttributeTargetObserver::create(toHTMLElement(this)->fastGetAttribute(formAttr), this);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
