Title: [153655] trunk/Source/WebCore
- Revision
- 153655
- Author
- [email protected]
- Date
- 2013-08-02 11:03:40 -0700 (Fri, 02 Aug 2013)
Log Message
Revert r153632, since it caused fast/forms/change-form-element-document-crash.html
to assert.
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore::FormAssociatedElement::resetFormAttributeTargetObserver):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153654 => 153655)
--- trunk/Source/WebCore/ChangeLog 2013-08-02 17:50:26 UTC (rev 153654)
+++ trunk/Source/WebCore/ChangeLog 2013-08-02 18:03:40 UTC (rev 153655)
@@ -1,3 +1,12 @@
+2013-08-02 Simon Fraser <[email protected]>
+
+ Revert r153632, since it caused fast/forms/change-form-element-document-crash.html
+ to assert.
+
+ * html/FormAssociatedElement.cpp:
+ (WebCore::FormAssociatedElement::formAttributeChanged):
+ (WebCore::FormAssociatedElement::resetFormAttributeTargetObserver):
+
2013-08-02 Mario Sanchez Prada <[email protected]>
Implement atk_text_get_text_*_offset for WORD
Modified: trunk/Source/WebCore/html/FormAssociatedElement.cpp (153654 => 153655)
--- trunk/Source/WebCore/html/FormAssociatedElement.cpp 2013-08-02 17:50:26 UTC (rev 153654)
+++ trunk/Source/WebCore/html/FormAssociatedElement.cpp 2013-08-02 18:03:40 UTC (rev 153655)
@@ -179,8 +179,7 @@
m_formAttributeTargetObserver = nullptr;
} else {
resetFormOwner();
- if (element->inDocument())
- resetFormAttributeTargetObserver();
+ resetFormAttributeTargetObserver();
}
}
@@ -254,7 +253,6 @@
void FormAssociatedElement::resetFormAttributeTargetObserver()
{
- ASSERT(toHTMLElement(this)->inDocument());
m_formAttributeTargetObserver = FormAttributeTargetObserver::create(toHTMLElement(this)->fastGetAttribute(formAttr), this);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
