Title: [153703] trunk
- Revision
- 153703
- Author
- [email protected]
- Date
- 2013-08-05 00:58:16 -0700 (Mon, 05 Aug 2013)
Log Message
[Automake] Define ENABLE_JIT through the Autoconf header
https://bugs.webkit.org/show_bug.cgi?id=119445
Reviewed by Martin Robinson.
.:
Instead of defining the ENABLE_JIT value through JSC_CPPFLAGS, the feature define is
set to be either enabled or disabled through the Autoconf header, based on the value
passed through the configuration flag. The 'auto' value is used as default, meaning
that the feature is enabled or disabled in the Platform.h header based on the platform
configuration (OS, architecture etc.).
* Source/autotools/FindDependencies.m4: Remove the JSC_CPPFLAGS definition.
* Source/autotools/ReadCommandLineArguments.m4: Change the default value to 'auto' instead
of 'autodetect', as used by other configuration options that take a similar approach to enabling
a specific feature.
* Source/autotools/SetupAutoconfHeader.m4: Set a strict value for the ENABLE_JIT define through
the Autoconf header if the feature was specifically enabled or disabled.
Source/_javascript_Core:
* GNUmakefile.am: Remove JSC_CPPFLAGS from the cpp flags for the JSC library.
Modified Paths
Diff
Modified: trunk/ChangeLog (153702 => 153703)
--- trunk/ChangeLog 2013-08-05 07:16:00 UTC (rev 153702)
+++ trunk/ChangeLog 2013-08-05 07:58:16 UTC (rev 153703)
@@ -1,3 +1,23 @@
+2013-08-05 Zan Dobersek <[email protected]>
+
+ [Automake] Define ENABLE_JIT through the Autoconf header
+ https://bugs.webkit.org/show_bug.cgi?id=119445
+
+ Reviewed by Martin Robinson.
+
+ Instead of defining the ENABLE_JIT value through JSC_CPPFLAGS, the feature define is
+ set to be either enabled or disabled through the Autoconf header, based on the value
+ passed through the configuration flag. The 'auto' value is used as default, meaning
+ that the feature is enabled or disabled in the Platform.h header based on the platform
+ configuration (OS, architecture etc.).
+
+ * Source/autotools/FindDependencies.m4: Remove the JSC_CPPFLAGS definition.
+ * Source/autotools/ReadCommandLineArguments.m4: Change the default value to 'auto' instead
+ of 'autodetect', as used by other configuration options that take a similar approach to enabling
+ a specific feature.
+ * Source/autotools/SetupAutoconfHeader.m4: Set a strict value for the ENABLE_JIT define through
+ the Autoconf header if the feature was specifically enabled or disabled.
+
2013-08-04 Zalan Bujtas <[email protected]>
Background doesn't fully repaint when body has margins.
Modified: trunk/Source/_javascript_Core/ChangeLog (153702 => 153703)
--- trunk/Source/_javascript_Core/ChangeLog 2013-08-05 07:16:00 UTC (rev 153702)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-08-05 07:58:16 UTC (rev 153703)
@@ -1,3 +1,12 @@
+2013-08-05 Zan Dobersek <[email protected]>
+
+ [Automake] Define ENABLE_JIT through the Autoconf header
+ https://bugs.webkit.org/show_bug.cgi?id=119445
+
+ Reviewed by Martin Robinson.
+
+ * GNUmakefile.am: Remove JSC_CPPFLAGS from the cpp flags for the JSC library.
+
2013-08-03 Filip Pizlo <[email protected]>
hasIndexingHeader() ought really to be a property of an object and its structure, not just its structure
Modified: trunk/Source/_javascript_Core/GNUmakefile.am (153702 => 153703)
--- trunk/Source/_javascript_Core/GNUmakefile.am 2013-08-05 07:16:00 UTC (rev 153702)
+++ trunk/Source/_javascript_Core/GNUmakefile.am 2013-08-05 07:58:16 UTC (rev 153703)
@@ -46,7 +46,6 @@
$(_javascript_core_cppflags)
_javascript_core_cppflags += \
- $(JSC_CPPFLAGS) \
-I$(srcdir)/Source \
-I$(srcdir)/Source/_javascript_Core \
-I$(srcdir)/Source/_javascript_Core/API \
Modified: trunk/Source/autotools/FindDependencies.m4 (153702 => 153703)
--- trunk/Source/autotools/FindDependencies.m4 2013-08-05 07:16:00 UTC (rev 153702)
+++ trunk/Source/autotools/FindDependencies.m4 2013-08-05 07:58:16 UTC (rev 153703)
@@ -312,14 +312,6 @@
fi
fi
-case "$enable_jit" in
- yes) JSC_CPPFLAGS="-DENABLE_JIT=1" ;;
- no) JSC_CPPFLAGS="-DENABLE_JIT=0" ;;
- *) enable_jit="autodetect" ;;
-esac
-AC_SUBST(JSC_CPPFLAGS)
-
-
# Enable CSS Filters and Shaders if accelerated_compositing is turned on.
enable_css_filters=no;
enable_css_shaders=no;
Modified: trunk/Source/autotools/ReadCommandLineArguments.m4 (153702 => 153703)
--- trunk/Source/autotools/ReadCommandLineArguments.m4 2013-08-05 07:16:00 UTC (rev 153702)
+++ trunk/Source/autotools/ReadCommandLineArguments.m4 2013-08-05 07:58:16 UTC (rev 153703)
@@ -182,7 +182,7 @@
AC_MSG_RESULT([$enable_accelerated_compositing])
AC_MSG_CHECKING([whether to enable JIT compilation])
-AC_ARG_ENABLE(jit, AS_HELP_STRING([--enable-jit], [Enable JIT compilation (default: autodetect)]))
+AC_ARG_ENABLE(jit, AS_HELP_STRING([--enable-jit], [Enable JIT compilation (default: auto)]), [], [enable_jit=auto])
AC_MSG_RESULT([$enable_jit])
AC_MSG_CHECKING([whether to enable opcode stats])
Modified: trunk/Source/autotools/SetupAutoconfHeader.m4 (153702 => 153703)
--- trunk/Source/autotools/SetupAutoconfHeader.m4 2013-08-05 07:16:00 UTC (rev 153702)
+++ trunk/Source/autotools/SetupAutoconfHeader.m4 2013-08-05 07:58:16 UTC (rev 153703)
@@ -94,3 +94,8 @@
AC_DEFINE([ENABLE_CREDENTIAL_STORAGE], [1], [ ])
fi
+if test "$enable_jit" = "yes"; then
+ AC_DEFINE([ENABLE_JIT], [1], [ ])
+elif test "$enable_jit" = "no"; then
+ AC_DEFINE([ENABLE_JIT], [0], [ ])
+fi
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
