Title: [153787] trunk/Source/WebCore
Revision
153787
Author
[email protected]
Date
2013-08-07 08:00:42 -0700 (Wed, 07 Aug 2013)

Log Message

Do no check seek offset against internal size on gstreamer source element
https://bugs.webkit.org/show_bug.cgi?id=116533

Patch by Andre Moreira Magalhaes <[email protected]> on 2013-08-07
Reviewed by Philippe Normand.

The internal size on gstreamer source element may be wrong in case the received size in
didReceiveResponse is not accurate. Lets just try to seek and let it fail if necessary.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcSeekDataCb):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (153786 => 153787)


--- trunk/Source/WebCore/ChangeLog	2013-08-07 14:31:03 UTC (rev 153786)
+++ trunk/Source/WebCore/ChangeLog	2013-08-07 15:00:42 UTC (rev 153787)
@@ -1,3 +1,16 @@
+2013-08-07  Andre Moreira Magalhaes   <[email protected]>
+
+        Do no check seek offset against internal size on gstreamer source element
+        https://bugs.webkit.org/show_bug.cgi?id=116533
+
+        Reviewed by Philippe Normand.
+
+        The internal size on gstreamer source element may be wrong in case the received size in
+        didReceiveResponse is not accurate. Lets just try to seek and let it fail if necessary.
+
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (webKitWebSrcSeekDataCb):
+
 2013-08-07  Antti Koivisto  <[email protected]>
 
         Create WebCore/style and move StyleResolveTree there

Modified: trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (153786 => 153787)


--- trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2013-08-07 14:31:03 UTC (rev 153786)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp	2013-08-07 15:00:42 UTC (rev 153787)
@@ -747,8 +747,6 @@
 
     if (!priv->seekable)
         return FALSE;
-    if (offset > priv->size)
-        return FALSE;
 
     GST_DEBUG_OBJECT(src, "Doing range-request seek");
     priv->requestedOffset = offset;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to