Title: [153798] trunk/Tools
- Revision
- 153798
- Author
- [email protected]
- Date
- 2013-08-07 14:13:41 -0700 (Wed, 07 Aug 2013)
Log Message
[EFL] REGRESSION after r153432: some accessibility tests crash.
https://bugs.webkit.org/show_bug.cgi?id=119333
Patch by Mario Sanchez Prada <[email protected]> on 2013-08-07
Reviewed by Darin Adler.
Use a RefPtr to store a reference to the parent element of
an AccessibilityUIElement instead of the raw pointer, so we
never derefence a function from an invalid pointer.
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (153797 => 153798)
--- trunk/Tools/ChangeLog 2013-08-07 19:52:37 UTC (rev 153797)
+++ trunk/Tools/ChangeLog 2013-08-07 21:13:41 UTC (rev 153798)
@@ -1,3 +1,17 @@
+2013-08-07 Mario Sanchez Prada <[email protected]>
+
+ [EFL] REGRESSION after r153432: some accessibility tests crash.
+ https://bugs.webkit.org/show_bug.cgi?id=119333
+
+ Reviewed by Darin Adler.
+
+ Use a RefPtr to store a reference to the parent element of
+ an AccessibilityUIElement instead of the raw pointer, so we
+ never derefence a function from an invalid pointer.
+
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+ (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
+
2013-08-07 Cosmin Truta <[email protected]>
Unreviewed. Add myself as a committer.
Modified: trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp (153797 => 153798)
--- trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-08-07 19:52:37 UTC (rev 153797)
+++ trunk/Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp 2013-08-07 21:13:41 UTC (rev 153798)
@@ -291,7 +291,7 @@
// For the parent we print its role and its name, if available.
builder.append("AXParent: ");
- AccessibilityUIElement* parent = element->parentElement().get();
+ RefPtr<AccessibilityUIElement> parent = element->parentElement();
AtkObject* atkParent = parent ? parent->platformUIElement().get() : 0;
if (atkParent) {
builder.append(roleToString(atk_object_get_role(atkParent)));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
