Title: [153811] trunk/Tools
- Revision
- 153811
- Author
- [email protected]
- Date
- 2013-08-07 19:13:14 -0700 (Wed, 07 Aug 2013)
Log Message
Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
https://bugs.webkit.org/show_bug.cgi?id=119317
Reviewed by Tim Horton.
The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
the test to complete, which is not power friendly. Although DRT instances
are generally busy anyway, not sitting in a busy loop should free up some CPU
cycles for other instances of DRT.
Editing tests continue to pass. All Java tests are skipped and were not
tested, but when run fail similarly with and without the patch.
* DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
(runTest):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (153810 => 153811)
--- trunk/Tools/ChangeLog 2013-08-08 02:00:07 UTC (rev 153810)
+++ trunk/Tools/ChangeLog 2013-08-08 02:13:14 UTC (rev 153811)
@@ -1,3 +1,22 @@
+2013-08-07 Simon Fraser <[email protected]>
+
+ Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
+ https://bugs.webkit.org/show_bug.cgi?id=119317
+
+ Reviewed by Tim Horton.
+
+ The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
+ the test to complete, which is not power friendly. Although DRT instances
+ are generally busy anyway, not sitting in a busy loop should free up some CPU
+ cycles for other instances of DRT.
+
+ Editing tests continue to pass. All Java tests are skipped and were not
+ tested, but when run fail similarly with and without the patch.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (dump):
+ (runTest):
+
2013-08-07 Daniel Bates <[email protected]>
Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (153810 => 153811)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2013-08-08 02:00:07 UTC (rev 153810)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2013-08-08 02:13:14 UTC (rev 153811)
@@ -1250,6 +1250,7 @@
fflush(stderr);
done = YES;
+ CFRunLoopStop(CFRunLoopGetMain());
}
static bool shouldLogFrameLoadDelegates(const char* pathOrURL)
@@ -1405,7 +1406,7 @@
while (!done) {
pool = [[NSAutoreleasePool alloc] init];
- [[NSRunLoop currentRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate distantPast]];
+ CFRunLoopRunInMode(kCFRunLoopDefaultMode, 10, false);
[pool release];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
