Title: [153897] trunk/LayoutTests
Revision
153897
Author
[email protected]
Date
2013-08-09 09:53:38 -0700 (Fri, 09 Aug 2013)

Log Message

move-by-word-visually-multi-space.html takes 21s and spends most of its time doing spelling and grammar checking
https://bugs.webkit.org/show_bug.cgi?id=119613

Reviewed by Darin Adler.

editing/selection tests are very slow, and much of the time is spent
doing spelling and grammar checking (which is not what these tests are
testing). So call internals.setContinuousSpellCheckingEnabled(false)
to turn that off.

* editing/selection/caret-at-bidi-boundary.html:
* editing/selection/move-by-character-brute-force.html:
* editing/selection/move-left-right.html:
* editing/selection/programmatic-selection-on-mac-is-directionless.html:
* editing/selection/resources/extend-selection.js:
* editing/selection/resources/move-by-word-visually.js:
(runTest):

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (153896 => 153897)


--- trunk/LayoutTests/ChangeLog	2013-08-09 16:07:29 UTC (rev 153896)
+++ trunk/LayoutTests/ChangeLog	2013-08-09 16:53:38 UTC (rev 153897)
@@ -1,3 +1,23 @@
+2013-08-09  Simon Fraser  <[email protected]>
+
+        move-by-word-visually-multi-space.html takes 21s and spends most of its time doing spelling and grammar checking
+        https://bugs.webkit.org/show_bug.cgi?id=119613
+
+        Reviewed by Darin Adler.
+        
+        editing/selection tests are very slow, and much of the time is spent
+        doing spelling and grammar checking (which is not what these tests are
+        testing). So call internals.setContinuousSpellCheckingEnabled(false)
+        to turn that off.
+
+        * editing/selection/caret-at-bidi-boundary.html:
+        * editing/selection/move-by-character-brute-force.html:
+        * editing/selection/move-left-right.html:
+        * editing/selection/programmatic-selection-on-mac-is-directionless.html:
+        * editing/selection/resources/extend-selection.js:
+        * editing/selection/resources/move-by-word-visually.js:
+        (runTest):
+
 2013-08-09  Bruno de Oliveira Abinader  <[email protected]>
 
         Text decorations should be listed as non-inheritable

Modified: trunk/LayoutTests/editing/selection/caret-at-bidi-boundary.html (153896 => 153897)


--- trunk/LayoutTests/editing/selection/caret-at-bidi-boundary.html	2013-08-09 16:07:29 UTC (rev 153896)
+++ trunk/LayoutTests/editing/selection/caret-at-bidi-boundary.html	2013-08-09 16:53:38 UTC (rev 153897)
@@ -86,6 +86,8 @@
 
 if (window.testRunner) {
     testRunner.dumpAsText();
+    if (window.internals)
+        internals.setContinuousSpellCheckingEnabled(false); // For performance.
 
     var tests = document.getElementById('tests').getElementsByTagName('dt');
     var testExpectations = document.getElementById('tests').getElementsByTagName('dd');

Modified: trunk/LayoutTests/editing/selection/move-by-character-brute-force.html (153896 => 153897)


--- trunk/LayoutTests/editing/selection/move-by-character-brute-force.html	2013-08-09 16:07:29 UTC (rev 153896)
+++ trunk/LayoutTests/editing/selection/move-by-character-brute-force.html	2013-08-09 16:53:38 UTC (rev 153897)
@@ -2,6 +2,9 @@
 <script src=""
 <div id="test"></div>
 <script>
+if (window.internals)
+    internals.setContinuousSpellCheckingEnabled(false); // For performance.
+
 description("This test checks that we have simple caret motion up to a certain limit");
 
 function hasSimpleCaretMovement(charCode) {

Modified: trunk/LayoutTests/editing/selection/move-left-right.html (153896 => 153897)


--- trunk/LayoutTests/editing/selection/move-left-right.html	2013-08-09 16:07:29 UTC (rev 153896)
+++ trunk/LayoutTests/editing/selection/move-left-right.html	2013-08-09 16:53:38 UTC (rev 153897)
@@ -134,6 +134,9 @@
 
         function runTest()
         {
+            if (window.internals)
+                internals.setContinuousSpellCheckingEnabled(false); // For performance.
+
             var tests = document.getElementsByClassName("test");
             var sel = getSelection();
             for (var i = 0; i < tests.length; ++i) {

Modified: trunk/LayoutTests/editing/selection/programmatic-selection-on-mac-is-directionless.html (153896 => 153897)


--- trunk/LayoutTests/editing/selection/programmatic-selection-on-mac-is-directionless.html	2013-08-09 16:07:29 UTC (rev 153896)
+++ trunk/LayoutTests/editing/selection/programmatic-selection-on-mac-is-directionless.html	2013-08-09 16:53:38 UTC (rev 153897)
@@ -27,6 +27,9 @@
 </div>
 
 <script>
+if (window.internals)
+    internals.setContinuousSpellCheckingEnabled(false); // For performance.
+
 description("This test ensures that programmatically set selections are directionless on mac, and that they are not on other platforms.");
 
 function selectLine(node) {

Modified: trunk/LayoutTests/editing/selection/resources/extend-selection.js (153896 => 153897)


--- trunk/LayoutTests/editing/selection/resources/extend-selection.js	2013-08-09 16:07:29 UTC (rev 153896)
+++ trunk/LayoutTests/editing/selection/resources/extend-selection.js	2013-08-09 16:53:38 UTC (rev 153897)
@@ -311,6 +311,9 @@
 }
 
 if (window.testRunner) {
+    if (window.internals)
+        internals.setContinuousSpellCheckingEnabled(false); // For performance.
+
     var originalOnload = window.onload;
     window._onload_ = function() {
         if (originalOnload)

Modified: trunk/LayoutTests/editing/selection/resources/move-by-word-visually.js (153896 => 153897)


--- trunk/LayoutTests/editing/selection/resources/move-by-word-visually.js	2013-08-09 16:07:29 UTC (rev 153896)
+++ trunk/LayoutTests/editing/selection/resources/move-by-word-visually.js	2013-08-09 16:53:38 UTC (rev 153897)
@@ -281,6 +281,9 @@
 }
 
 function runTest() {
+    if (window.internals)
+        internals.setContinuousSpellCheckingEnabled(false); // For performance.
+    
     log("\n======== Move By Word ====\n");
     var tests = document.getElementsByClassName("test_move_by_word");
     runMoveLeftRight(tests, "word");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to