Title: [153914] trunk
- Revision
- 153914
- Author
- [email protected]
- Date
- 2013-08-09 16:30:32 -0700 (Fri, 09 Aug 2013)
Log Message
ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff
https://bugs.webkit.org/show_bug.cgi?id=119623
Reviewed by Dirk Schulze.
Source/WebCore:
Include all the stroke attributes in the style diff comparison, the visited links ones were missing.
Test: svg/animations/animate-stroke-crasher.html
* rendering/style/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::diff):
LayoutTests:
Add testcase from bug with small adjustments.
* svg/animations/animate-stroke-crasher-expected.txt: Added.
* svg/animations/animate-stroke-crasher.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (153913 => 153914)
--- trunk/LayoutTests/ChangeLog 2013-08-09 23:25:11 UTC (rev 153913)
+++ trunk/LayoutTests/ChangeLog 2013-08-09 23:30:32 UTC (rev 153914)
@@ -1,3 +1,15 @@
+2013-08-09 Rob Buis <[email protected]>
+
+ ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff
+ https://bugs.webkit.org/show_bug.cgi?id=119623
+
+ Reviewed by Dirk Schulze.
+
+ Add testcase from bug with small adjustments.
+
+ * svg/animations/animate-stroke-crasher-expected.txt: Added.
+ * svg/animations/animate-stroke-crasher.html: Added.
+
2013-08-09 Alexey Proskuryakov <[email protected]>
REGRESSION (r142755): window.open creates an invisible window when width and height are 0
Added: trunk/LayoutTests/svg/animations/animate-stroke-crasher-expected.txt (0 => 153914)
--- trunk/LayoutTests/svg/animations/animate-stroke-crasher-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/animations/animate-stroke-crasher-expected.txt 2013-08-09 23:30:32 UTC (rev 153914)
@@ -0,0 +1,2 @@
+PASS
+
Added: trunk/LayoutTests/svg/animations/animate-stroke-crasher.html (0 => 153914)
--- trunk/LayoutTests/svg/animations/animate-stroke-crasher.html (rev 0)
+++ trunk/LayoutTests/svg/animations/animate-stroke-crasher.html 2013-08-09 23:30:32 UTC (rev 153914)
@@ -0,0 +1,14 @@
+<!DOCTYPE HTML>
+<html>
+ <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+ </script>
+ <text stroke="#666">PASS
+ <a xlink:href=""
+ <animate attributename="stroke"></animate>
+ </a>
+ </text>
+ </svg>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (153913 => 153914)
--- trunk/Source/WebCore/ChangeLog 2013-08-09 23:25:11 UTC (rev 153913)
+++ trunk/Source/WebCore/ChangeLog 2013-08-09 23:30:32 UTC (rev 153914)
@@ -1,3 +1,17 @@
+2013-08-09 Rob Buis <[email protected]>
+
+ ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff
+ https://bugs.webkit.org/show_bug.cgi?id=119623
+
+ Reviewed by Dirk Schulze.
+
+ Include all the stroke attributes in the style diff comparison, the visited links ones were missing.
+
+ Test: svg/animations/animate-stroke-crasher.html
+
+ * rendering/style/SVGRenderStyle.cpp:
+ (WebCore::SVGRenderStyle::diff):
+
2013-08-09 Alexey Proskuryakov <[email protected]>
REGRESSION (r142755): window.open creates an invisible window when width and height are 0
Modified: trunk/Source/WebCore/rendering/style/SVGRenderStyle.cpp (153913 => 153914)
--- trunk/Source/WebCore/rendering/style/SVGRenderStyle.cpp 2013-08-09 23:25:11 UTC (rev 153913)
+++ trunk/Source/WebCore/rendering/style/SVGRenderStyle.cpp 2013-08-09 23:30:32 UTC (rev 153914)
@@ -183,7 +183,10 @@
|| stroke->paintUri != other->stroke->paintUri
|| stroke->miterLimit != other->stroke->miterLimit
|| stroke->dashArray != other->stroke->dashArray
- || stroke->dashOffset != other->stroke->dashOffset)
+ || stroke->dashOffset != other->stroke->dashOffset
+ || stroke->visitedLinkPaintColor != other->stroke->visitedLinkPaintColor
+ || stroke->visitedLinkPaintUri != other->stroke->visitedLinkPaintUri
+ || stroke->visitedLinkPaintType != other->stroke->visitedLinkPaintType)
return StyleDifferenceLayout;
// Only the stroke-opacity case remains, where we only need a repaint.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
