Title: [153917] trunk/Source/WebCore
- Revision
- 153917
- Author
- [email protected]
- Date
- 2013-08-09 17:36:10 -0700 (Fri, 09 Aug 2013)
Log Message
Artifacts seen sometimes with layer backed WebKit1 plug-in
https://bugs.webkit.org/show_bug.cgi?id=119647
<rdar://problem/14002715>
Reviewed by Beth Dakin.
Don't try to paint layer backed views - they will be painted by Core Animation.
* platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153916 => 153917)
--- trunk/Source/WebCore/ChangeLog 2013-08-10 00:07:43 UTC (rev 153916)
+++ trunk/Source/WebCore/ChangeLog 2013-08-10 00:36:10 UTC (rev 153917)
@@ -1,3 +1,16 @@
+2013-08-09 Anders Carlsson <[email protected]>
+
+ Artifacts seen sometimes with layer backed WebKit1 plug-in
+ https://bugs.webkit.org/show_bug.cgi?id=119647
+ <rdar://problem/14002715>
+
+ Reviewed by Beth Dakin.
+
+ Don't try to paint layer backed views - they will be painted by Core Animation.
+
+ * platform/mac/WidgetMac.mm:
+ (WebCore::Widget::paint):
+
2013-08-09 Rob Buis <[email protected]>
ASSERTION FAILED: stroke->opacity != other->stroke->opacity in WebCore::SVGRenderStyle::diff
Modified: trunk/Source/WebCore/platform/mac/WidgetMac.mm (153916 => 153917)
--- trunk/Source/WebCore/platform/mac/WidgetMac.mm 2013-08-10 00:07:43 UTC (rev 153916)
+++ trunk/Source/WebCore/platform/mac/WidgetMac.mm 2013-08-10 00:36:10 UTC (rev 153917)
@@ -204,6 +204,12 @@
return;
NSView *view = getOuterView();
+ // We don't want to paint the view at all if it's layer backed, because then we'll end up
+ // with multiple copies of the view contents, one in the view's layer itself and one in the
+ // WebHTMLView's backing store (either a layer or the window backing store).
+ if (view.layer)
+ return;
+
// Take a reference to this Widget, because sending messages to the views can invoke arbitrary
// code, which can deref it.
RefPtr<Widget> protectedThis(this);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
