Title: [153975] trunk/Source/WebCore
Revision
153975
Author
[email protected]
Date
2013-08-12 22:48:32 -0700 (Mon, 12 Aug 2013)

Log Message

Fix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=119716

Reviewed by Darin Adler.

Merge https://chromium.googlesource.com/chromium/blink/+/d5783da353ab783e9994b8fbecd91880be5192a1

No new tests since the test in the Blink change doesn't reproduce crash on WebKit.

* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::sendPings):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (153974 => 153975)


--- trunk/Source/WebCore/ChangeLog	2013-08-13 05:47:27 UTC (rev 153974)
+++ trunk/Source/WebCore/ChangeLog	2013-08-13 05:48:32 UTC (rev 153975)
@@ -1,3 +1,17 @@
+2013-08-12  Ryosuke Niwa  <[email protected]>
+
+        Fix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist
+        https://bugs.webkit.org/show_bug.cgi?id=119716
+
+        Reviewed by Darin Adler.
+
+        Merge https://chromium.googlesource.com/chromium/blink/+/d5783da353ab783e9994b8fbecd91880be5192a1
+
+        No new tests since the test in the Blink change doesn't reproduce crash on WebKit.
+
+        * html/HTMLAnchorElement.cpp:
+        (WebCore::HTMLAnchorElement::sendPings):
+
 2013-08-12  Seokju Kwon  <[email protected]>
 
         Use the correct preprocessor in shouldRepaintFixedBackgroundsOnScroll()

Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (153974 => 153975)


--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp	2013-08-13 05:47:27 UTC (rev 153974)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp	2013-08-13 05:48:32 UTC (rev 153975)
@@ -512,7 +512,7 @@
 
 void HTMLAnchorElement::sendPings(const KURL& destinationURL)
 {
-    if (!hasAttribute(pingAttr) || !document()->settings()->hyperlinkAuditingEnabled())
+    if (!hasAttribute(pingAttr) || !document()->settings() || !document()->settings()->hyperlinkAuditingEnabled())
         return;
 
     SpaceSplitString pingURLs(getAttribute(pingAttr), false);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to