Title: [154018] trunk/Source/WebCore
- Revision
- 154018
- Author
- [email protected]
- Date
- 2013-08-13 13:18:30 -0700 (Tue, 13 Aug 2013)
Log Message
Every scroll causes additional layer tree work because of flatteningLayer->removeFromParent();
https://bugs.webkit.org/show_bug.cgi?id=119551
Reviewed by Dean Jackson.
Only re-parent the flattening layer if we had to update our
layer configuration (reparenting is necessary then to get
the correct sibling ordering), or if it was parented in some
other layer.
This avoid unnecessary flushing of state to CA.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (154017 => 154018)
--- trunk/Source/WebCore/ChangeLog 2013-08-13 20:07:09 UTC (rev 154017)
+++ trunk/Source/WebCore/ChangeLog 2013-08-13 20:18:30 UTC (rev 154018)
@@ -1,3 +1,20 @@
+2013-08-13 Simon Fraser <[email protected]>
+
+ Every scroll causes additional layer tree work because of flatteningLayer->removeFromParent();
+ https://bugs.webkit.org/show_bug.cgi?id=119551
+
+ Reviewed by Dean Jackson.
+
+ Only re-parent the flattening layer if we had to update our
+ layer configuration (reparenting is necessary then to get
+ the correct sibling ordering), or if it was parented in some
+ other layer.
+
+ This avoid unnecessary flushing of state to CA.
+
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
+
2013-08-13 Robert Hogan <[email protected]>
Section's collapsed borders painted in wrong place in rtl tables
Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (154017 => 154018)
--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2013-08-13 20:07:09 UTC (rev 154017)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp 2013-08-13 20:18:30 UTC (rev 154018)
@@ -539,8 +539,8 @@
updateInternalHierarchy();
if (GraphicsLayer* flatteningLayer = tileCacheFlatteningLayer()) {
- flatteningLayer->removeFromParent();
- m_graphicsLayer->addChild(flatteningLayer);
+ if (layerConfigChanged || flatteningLayer->parent() != m_graphicsLayer)
+ m_graphicsLayer->addChild(flatteningLayer);
}
if (updateMaskLayer(renderer->hasMask()))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes