Title: [154027] trunk/Tools
- Revision
- 154027
- Author
- [email protected]
- Date
- 2013-08-13 15:48:43 -0700 (Tue, 13 Aug 2013)
Log Message
[Mac] fast/dom/attr-style-too-lazy.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=119763
Reviewed by Darin Adler.
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
a test, it would just semi-randomly leak to the next one.
(-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
for good measure.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (154026 => 154027)
--- trunk/Tools/ChangeLog 2013-08-13 22:47:15 UTC (rev 154026)
+++ trunk/Tools/ChangeLog 2013-08-13 22:48:43 UTC (rev 154027)
@@ -1,3 +1,16 @@
+2013-08-13 Alexey Proskuryakov <[email protected]>
+
+ [Mac] fast/dom/attr-style-too-lazy.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=119763
+
+ Reviewed by Darin Adler.
+
+ * DumpRenderTree/mac/UIDelegate.mm:
+ (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
+ a test, it would just semi-randomly leak to the next one.
+ (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
+ for good measure.
+
2013-08-13 Tim Horton <[email protected]>
[mac] Give MiniBrowser a reasonable bundle identifier
Modified: trunk/Tools/DumpRenderTree/mac/UIDelegate.mm (154026 => 154027)
--- trunk/Tools/DumpRenderTree/mac/UIDelegate.mm 2013-08-13 22:47:15 UTC (rev 154026)
+++ trunk/Tools/DumpRenderTree/mac/UIDelegate.mm 2013-08-13 22:48:43 UTC (rev 154027)
@@ -197,7 +197,7 @@
- (void)webView:(WebView *)sender setStatusText:(NSString *)text
{
- if (gTestRunner->dumpStatusCallbacks())
+ if (!done && gTestRunner->dumpStatusCallbacks())
printf("UI DELEGATE STATUS CALLBACK: setStatusText:%s\n", [text UTF8String]);
}
@@ -290,7 +290,8 @@
- (BOOL)webView:(WebView *)webView didPressMissingPluginButton:(DOMElement *)element
{
- printf("MISSING PLUGIN BUTTON PRESSED\n");
+ if (!done)
+ printf("MISSING PLUGIN BUTTON PRESSED\n");
return TRUE;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes