Title: [154053] trunk
Revision
154053
Author
[email protected]
Date
2013-08-14 09:52:00 -0700 (Wed, 14 Aug 2013)

Log Message

[Qt] Activate visibility API layout tests
https://bugs.webkit.org/show_bug.cgi?id=119790

Patch by Benjamin Dupont <[email protected]> on 2013-08-14
Reviewed by Allan Sandfeld Jensen.

Tools:

* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):

LayoutTests:

* platform/qt/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (154052 => 154053)


--- trunk/LayoutTests/ChangeLog	2013-08-14 16:51:10 UTC (rev 154052)
+++ trunk/LayoutTests/ChangeLog	2013-08-14 16:52:00 UTC (rev 154053)
@@ -1,3 +1,12 @@
+2013-08-14  Benjamin Dupont   <[email protected]>
+
+        [Qt] Activate visibility API layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=119790
+
+        Reviewed by Allan Sandfeld Jensen.
+
+        * platform/qt/TestExpectations:
+
 2013-08-14  Rob Buis  <[email protected]>
 
         ASSERTION FAILED: resultAnimationElement->m_animatedType in WebCore::SVGAnimateElement::calculateAnimatedValue

Modified: trunk/LayoutTests/platform/qt/TestExpectations (154052 => 154053)


--- trunk/LayoutTests/platform/qt/TestExpectations	2013-08-14 16:51:10 UTC (rev 154052)
+++ trunk/LayoutTests/platform/qt/TestExpectations	2013-08-14 16:52:00 UTC (rev 154053)
@@ -441,14 +441,6 @@
 fast/images/exif-orientation.html
 fast/images/exif-orientation-css.html
 
-# This platform does not support the Page Visibility API.
-fast/events/page-visibility-iframe-delete-test.html
-fast/events/page-visibility-iframe-move-test.html
-fast/events/page-visibility-iframe-propagation-test.html
-fast/events/page-visibility-null-view.html
-fast/events/page-visibility-transition-test.html
-fast/frames/page-visibility-crash.html
-
 # No CORS support for media elements is implemented yet.
 http/tests/security/video-cross-origin-readback.html
 

Modified: trunk/Tools/ChangeLog (154052 => 154053)


--- trunk/Tools/ChangeLog	2013-08-14 16:51:10 UTC (rev 154052)
+++ trunk/Tools/ChangeLog	2013-08-14 16:52:00 UTC (rev 154053)
@@ -1,3 +1,14 @@
+2013-08-14  Benjamin Dupont   <[email protected]>
+
+        [Qt] Activate visibility API layout tests
+        https://bugs.webkit.org/show_bug.cgi?id=119790
+
+        Reviewed by Allan Sandfeld Jensen.
+
+        * DumpRenderTree/qt/TestRunnerQt.cpp:
+        (TestRunner::resetPageVisibility):
+        (TestRunner::setPageVisibility):
+
 2013-08-13  Xabier Rodriguez Calvar  <[email protected]>
 
         [GTK] WK does not link properly against libxslt

Modified: trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp (154052 => 154053)


--- trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp	2013-08-14 16:51:10 UTC (rev 154052)
+++ trunk/Tools/DumpRenderTree/qt/TestRunnerQt.cpp	2013-08-14 16:52:00 UTC (rev 154053)
@@ -950,8 +950,22 @@
 
 void TestRunner::resetPageVisibility()
 {
+    // No need to implement it because the visibility state is correctly initialised when the page is created.
 }
 
+void TestRunner::setPageVisibility(const char* visibility)
+{
+    QLatin1String newVisibility = QLatin1String(visibility);
+    if (newVisibility == QStringLiteral("visible"))
+        DumpRenderTree::instance()->webPage()->setVisibilityState(QWebPage::VisibilityStateVisible);
+    else if (newVisibility == QStringLiteral("hidden"))
+        DumpRenderTree::instance()->webPage()->setVisibilityState(QWebPage::VisibilityStateHidden);
+    else if (newVisibility == QStringLiteral("prerender"))
+        DumpRenderTree::instance()->webPage()->setVisibilityState(QWebPage::VisibilityStatePrerender);
+    else if (newVisibility == QStringLiteral("unloaded"))
+        DumpRenderTree::instance()->webPage()->setVisibilityState(QWebPage::VisibilityStateUnloaded);
+}
+
 void TestRunner::keepWebHistory()
 {
 }
@@ -1146,10 +1160,6 @@
 {
 }
 
-void TestRunner::setPageVisibility(const char *)
-{
-}
-
 void TestRunner::addMockSpeechInputResult(JSStringRef result, double confidence, JSStringRef language)
 {
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to