Title: [154064] trunk
Revision
154064
Author
[email protected]
Date
2013-08-14 12:14:00 -0700 (Wed, 14 Aug 2013)

Log Message

Assertion failure in RenderObject::drawLineForBoxSide
https://bugs.webkit.org/show_bug.cgi?id=108187

Reviewed by David Hyatt.

Source/WebCore:

Don't draw the outline if the rectangle to draw is empty.

Test: fast/css/outline-negative.html

* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine):

LayoutTests:

Add testcase from bug with small adjustments.

* fast/css/outline-negative-expected.txt: Added.
* fast/css/outline-negative.html: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (154063 => 154064)


--- trunk/LayoutTests/ChangeLog	2013-08-14 18:52:34 UTC (rev 154063)
+++ trunk/LayoutTests/ChangeLog	2013-08-14 19:14:00 UTC (rev 154064)
@@ -1,3 +1,15 @@
+2013-08-14  Rob Buis  <[email protected]>
+
+        Assertion failure in RenderObject::drawLineForBoxSide
+        https://bugs.webkit.org/show_bug.cgi?id=108187
+
+        Reviewed by David Hyatt.
+
+        Add testcase from bug with small adjustments.
+
+        * fast/css/outline-negative-expected.txt: Added.
+        * fast/css/outline-negative.html: Added.
+
 2013-08-14  Andreas Kling  <[email protected]>
 
         REGRESSION(r153815): fast/repaint/caret-jump-between-nodes.html sucks.

Added: trunk/LayoutTests/fast/css/outline-negative-expected.txt (0 => 154064)


--- trunk/LayoutTests/fast/css/outline-negative-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/css/outline-negative-expected.txt	2013-08-14 19:14:00 UTC (rev 154064)
@@ -0,0 +1 @@
+PASS

Added: trunk/LayoutTests/fast/css/outline-negative.html (0 => 154064)


--- trunk/LayoutTests/fast/css/outline-negative.html	                        (rev 0)
+++ trunk/LayoutTests/fast/css/outline-negative.html	2013-08-14 19:14:00 UTC (rev 154064)
@@ -0,0 +1,9 @@
+<html>
+  <script>
+    if (window.testRunner)
+      testRunner.dumpAsText();
+  </script>
+  <body>
+      <a style="outline: solid; outline-offset: -70px;">PASS</a>
+  </body>
+</html>

Modified: trunk/Source/WebCore/ChangeLog (154063 => 154064)


--- trunk/Source/WebCore/ChangeLog	2013-08-14 18:52:34 UTC (rev 154063)
+++ trunk/Source/WebCore/ChangeLog	2013-08-14 19:14:00 UTC (rev 154064)
@@ -1,3 +1,17 @@
+2013-08-14  Rob Buis  <[email protected]>
+
+        Assertion failure in RenderObject::drawLineForBoxSide
+        https://bugs.webkit.org/show_bug.cgi?id=108187
+
+        Reviewed by David Hyatt.
+
+        Don't draw the outline if the rectangle to draw is empty.
+
+        Test: fast/css/outline-negative.html
+
+        * rendering/RenderInline.cpp:
+        (WebCore::RenderInline::paintOutlineForLine):
+
 2013-08-13  Chris Fleizach  <[email protected]>
 
         AX: Headings not longer have an AXTitle if they have a link as the only child

Modified: trunk/Source/WebCore/rendering/RenderInline.cpp (154063 => 154064)


--- trunk/Source/WebCore/rendering/RenderInline.cpp	2013-08-14 18:52:34 UTC (rev 154063)
+++ trunk/Source/WebCore/rendering/RenderInline.cpp	2013-08-14 19:14:00 UTC (rev 154064)
@@ -1476,6 +1476,8 @@
         LayoutSize(thisline.width() + offset, thisline.height() + offset));
 
     IntRect pixelSnappedBox = pixelSnappedIntRect(box);
+    if (pixelSnappedBox.isEmpty())
+        return;
     IntRect pixelSnappedLastLine = pixelSnappedIntRect(paintOffset.x() + lastline.x(), 0, lastline.width(), 0);
     IntRect pixelSnappedNextLine = pixelSnappedIntRect(paintOffset.x() + nextline.x(), 0, nextline.width(), 0);
     
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to