Title: [154087] trunk/Source/WebCore
- Revision
- 154087
- Author
- [email protected]
- Date
- 2013-08-14 17:53:02 -0700 (Wed, 14 Aug 2013)
Log Message
Update binding test results. Follow up fix for <https://webkit.org/b/119664>
* bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::JSTestCallback):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (154086 => 154087)
--- trunk/Source/WebCore/ChangeLog 2013-08-15 00:45:01 UTC (rev 154086)
+++ trunk/Source/WebCore/ChangeLog 2013-08-15 00:53:02 UTC (rev 154087)
@@ -1,3 +1,12 @@
+2013-08-14 Sam Weinig <[email protected]>
+
+ Update binding test results. Follow up fix for <https://webkit.org/b/119664>
+
+ * bindings/scripts/test/JS/JSTestCallback.cpp:
+ (WebCore::JSTestCallback::JSTestCallback):
+ * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
+ (WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
+
2013-08-14 Joseph Pecoraro <[email protected]>
<https://webkit.org/b/119810> [Mac] No AutoreleasePool leaks when dragging image out of WebView
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp (154086 => 154087)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp 2013-08-15 00:45:01 UTC (rev 154086)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp 2013-08-15 00:53:02 UTC (rev 154087)
@@ -36,7 +36,8 @@
namespace WebCore {
JSTestCallback::JSTestCallback(JSObject* callback, JSDOMGlobalObject* globalObject)
- : ActiveDOMCallback(globalObject->scriptExecutionContext())
+ : TestCallback()
+ , ActiveDOMCallback(globalObject->scriptExecutionContext())
, m_data(new JSCallbackData(callback, globalObject))
{
}
@@ -55,6 +56,7 @@
#endif
}
+
// Functions
bool JSTestCallback::callbackWithNoParam()
Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp (154086 => 154087)
--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp 2013-08-15 00:45:01 UTC (rev 154086)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp 2013-08-15 00:53:02 UTC (rev 154087)
@@ -23,7 +23,7 @@
#include "ExceptionCode.h"
#include "JSDOMBinding.h"
-#include "MediaQueryListListener.h"
+#include "JSMediaQueryListListener.h"
#include "TestMediaQueryListListener.h"
#include <runtime/Error.h>
#include <wtf/GetPtr.h>
@@ -167,9 +167,9 @@
TestMediaQueryListListener* impl = static_cast<TestMediaQueryListListener*>(castedThis->impl());
if (exec->argumentCount() < 1)
return throwVMError(exec, createNotEnoughArgumentsError(exec));
- RefPtr<MediaQueryListListener> listener(MediaQueryListListener::create(ScriptValue(exec->vm(), exec->argument(0))));
- if (exec->hadException())
- return JSValue::encode(jsUndefined());
+ if (exec->argumentCount() <= 0 || !exec->argument(0).isFunction())
+ return throwVMTypeError(exec);
+ RefPtr<MediaQueryListListener> listener = JSMediaQueryListListener::create(asObject(exec->argument(0)), castedThis->globalObject());
impl->method(listener);
return JSValue::encode(jsUndefined());
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
