Title: [154104] branches/safari-537-branch/Source/WebCore
- Revision
- 154104
- Author
- [email protected]
- Date
- 2013-08-15 09:44:33 -0700 (Thu, 15 Aug 2013)
Log Message
Merged r154083. <rdar://problem/14719187>
Modified Paths
Diff
Modified: branches/safari-537-branch/Source/WebCore/ChangeLog (154103 => 154104)
--- branches/safari-537-branch/Source/WebCore/ChangeLog 2013-08-15 16:24:00 UTC (rev 154103)
+++ branches/safari-537-branch/Source/WebCore/ChangeLog 2013-08-15 16:44:33 UTC (rev 154104)
@@ -1,3 +1,24 @@
+2013-08-15 Lucas Forschler <[email protected]>
+
+ Merge r154083
+
+ 2013-08-14 Chris Fleizach <[email protected]>
+
+ <https://webkit.org/b/119824> AX: WKView does not become first responder when the voiceover cursor lands on it
+
+ Reviewed by Tim Horton.
+
+ VoiceOver lands on Scroll views by default. It expects that the scroll view will be able to handle the focus calls.
+ We should forward scroll view focus requests to the web area to handle, which will trigger a becomeFirstResponder on WKView.
+
+ There's not a great way to test this unfortunately, since it requires having focus comes from outside the webview into the webview.
+
+ * accessibility/AccessibilityScrollView.cpp:
+ (WebCore::AccessibilityScrollView::canSetFocusAttribute):
+ (WebCore::AccessibilityScrollView::isFocused):
+ (WebCore::AccessibilityScrollView::setFocused):
+ * accessibility/AccessibilityScrollView.h:
+
2013-08-14 Lucas Forschler <[email protected]>
Merge r154030
Modified: branches/safari-537-branch/Source/WebCore/accessibility/AccessibilityScrollView.cpp (154103 => 154104)
--- branches/safari-537-branch/Source/WebCore/accessibility/AccessibilityScrollView.cpp 2013-08-15 16:24:00 UTC (rev 154103)
+++ branches/safari-537-branch/Source/WebCore/accessibility/AccessibilityScrollView.cpp 2013-08-15 16:44:33 UTC (rev 154104)
@@ -86,6 +86,26 @@
return m_scrollView;
}
+bool AccessibilityScrollView::canSetFocusAttribute() const
+{
+ if (AccessibilityObject* webArea = webAreaObject())
+ return webArea->canSetFocusAttribute();
+ return false;
+}
+
+bool AccessibilityScrollView::isFocused() const
+{
+ if (AccessibilityObject* webArea = webAreaObject())
+ return webArea->isFocused();
+ return false;
+}
+
+void AccessibilityScrollView::setFocused(bool focused)
+{
+ if (AccessibilityObject* webArea = webAreaObject())
+ webArea->setFocused(focused);
+}
+
void AccessibilityScrollView::updateChildrenIfNecessary()
{
if (m_childrenDirty)
Modified: branches/safari-537-branch/Source/WebCore/accessibility/AccessibilityScrollView.h (154103 => 154104)
--- branches/safari-537-branch/Source/WebCore/accessibility/AccessibilityScrollView.h 2013-08-15 16:24:00 UTC (rev 154103)
+++ branches/safari-537-branch/Source/WebCore/accessibility/AccessibilityScrollView.h 2013-08-15 16:44:33 UTC (rev 154104)
@@ -64,6 +64,9 @@
virtual void updateChildrenIfNecessary();
virtual void setNeedsToUpdateChildren() { m_childrenDirty = true; }
void updateScrollbars();
+ virtual void setFocused(bool);
+ virtual bool canSetFocusAttribute() const;
+ virtual bool isFocused() const;
virtual FrameView* documentFrameView() const;
virtual LayoutRect elementRect() const;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
