Title: [154186] trunk
- Revision
- 154186
- Author
- [email protected]
- Date
- 2013-08-16 09:03:29 -0700 (Fri, 16 Aug 2013)
Log Message
[Qt] Kerning in fast font path breaks letter-spacing
https://bugs.webkit.org/show_bug.cgi?id=119838
Reviewed by Jocelyn Turcotte.
Source/WebCore:
Mark fonts with both kerning and letter-spacing as unsupported by the simple font-path.
Test: fast/text/letter-spacing-kerned.html
* platform/graphics/WidthIterator.h:
(WebCore::WidthIterator::supportsTypesettingFeatures):
LayoutTests:
Test that kerning does not break letter spacing.
* fast/text/letter-spacing-kerned-expected.html: Added.
* fast/text/letter-spacing-kerned.html: Added.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (154185 => 154186)
--- trunk/LayoutTests/ChangeLog 2013-08-16 15:52:52 UTC (rev 154185)
+++ trunk/LayoutTests/ChangeLog 2013-08-16 16:03:29 UTC (rev 154186)
@@ -1,3 +1,15 @@
+2013-08-16 Allan Sandfeld Jensen <[email protected]>
+
+ [Qt] Kerning in fast font path breaks letter-spacing
+ https://bugs.webkit.org/show_bug.cgi?id=119838
+
+ Reviewed by Jocelyn Turcotte.
+
+ Test that kerning does not break letter spacing.
+
+ * fast/text/letter-spacing-kerned-expected.html: Added.
+ * fast/text/letter-spacing-kerned.html: Added.
+
2013-08-16 Brent Fulgham <[email protected]>
[Windows] Unreviewed gardening. Turn on a now-passing test.
Modified: trunk/Source/WebCore/ChangeLog (154185 => 154186)
--- trunk/Source/WebCore/ChangeLog 2013-08-16 15:52:52 UTC (rev 154185)
+++ trunk/Source/WebCore/ChangeLog 2013-08-16 16:03:29 UTC (rev 154186)
@@ -1,3 +1,17 @@
+2013-08-16 Allan Sandfeld Jensen <[email protected]>
+
+ [Qt] Kerning in fast font path breaks letter-spacing
+ https://bugs.webkit.org/show_bug.cgi?id=119838
+
+ Reviewed by Jocelyn Turcotte.
+
+ Mark fonts with both kerning and letter-spacing as unsupported by the simple font-path.
+
+ Test: fast/text/letter-spacing-kerned.html
+
+ * platform/graphics/WidthIterator.h:
+ (WebCore::WidthIterator::supportsTypesettingFeatures):
+
2013-08-16 Andreas Kling <[email protected]>
<https://webkit.org/b/119893> FrameView::frame() should return a reference.
Modified: trunk/Source/WebCore/platform/graphics/WidthIterator.h (154185 => 154186)
--- trunk/Source/WebCore/platform/graphics/WidthIterator.h 2013-08-16 15:52:52 UTC (rev 154185)
+++ trunk/Source/WebCore/platform/graphics/WidthIterator.h 2013-08-16 16:03:29 UTC (rev 154186)
@@ -67,7 +67,7 @@
return !(font.typesettingFeatures() & ~(Kerning | Ligatures));
#elif PLATFORM(QT) && QT_VERSION >= 0x050100
- return !(font.typesettingFeatures() & ~Kerning) && !font.isSmallCaps();
+ return !(font.typesettingFeatures() & ~Kerning) && !font.isSmallCaps() && !font.letterSpacing();
#else
return !font.typesettingFeatures();
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
