Diff
Modified: trunk/Source/WebCore/ChangeLog (154234 => 154235)
--- trunk/Source/WebCore/ChangeLog 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebCore/ChangeLog 2013-08-17 16:58:14 UTC (rev 154235)
@@ -1,3 +1,20 @@
+2013-08-17 Andreas Kling <[email protected]>
+
+ <https://webkit.org/b/119950> Remove unused EditorClient::frameWillDetachPage() callback.
+
+ Reviewed by Antti Koivisto.
+
+ This callback was only used by the Chromium port.
+
+ * editing/Editor.h:
+ * editing/Editor.cpp:
+
+ Remove override of FrameDestructionObserver::willDetachPage().
+
+ * page/EditorClient.h:
+
+ Remove frameWillDetachPage(). This is repeated in every EditorClient subclass.
+
2013-08-16 Antti Koivisto <[email protected]>
<https://webkit.org/b/119886> PseudoElement is abusing parent node pointer
Modified: trunk/Source/WebCore/editing/Editor.cpp (154234 => 154235)
--- trunk/Source/WebCore/editing/Editor.cpp 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebCore/editing/Editor.cpp 2013-08-17 16:58:14 UTC (rev 154235)
@@ -3108,12 +3108,6 @@
return WebCore::unifiedTextCheckerEnabled(m_frame);
}
-void Editor::willDetachPage()
-{
- if (EditorClient* editorClient = client())
- editorClient->frameWillDetachPage(frame());
-}
-
Vector<String> Editor::dictationAlternativesForMarker(const DocumentMarker* marker)
{
return m_alternativeTextController->dictationAlternativesForMarker(marker);
Modified: trunk/Source/WebCore/editing/Editor.h (154234 => 154235)
--- trunk/Source/WebCore/editing/Editor.h 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebCore/editing/Editor.h 2013-08-17 16:58:14 UTC (rev 154235)
@@ -415,8 +415,6 @@
Vector<String> dictationAlternativesForMarker(const DocumentMarker*);
void applyDictationAlternativelternative(const String& alternativeString);
private:
- virtual void willDetachPage() OVERRIDE;
-
#if ENABLE(DELETION_UI)
OwnPtr<DeleteButtonController> m_deleteButtonController;
#endif
Modified: trunk/Source/WebCore/loader/EmptyClients.h (154234 => 154235)
--- trunk/Source/WebCore/loader/EmptyClients.h 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebCore/loader/EmptyClients.h 2013-08-17 16:58:14 UTC (rev 154235)
@@ -397,7 +397,6 @@
EmptyEditorClient() { }
virtual ~EmptyEditorClient() { }
virtual void pageDestroyed() { }
- virtual void frameWillDetachPage(Frame*) { }
virtual bool shouldDeleteRange(Range*) { return false; }
virtual bool smartInsertDeleteEnabled() { return false; }
Modified: trunk/Source/WebCore/page/EditorClient.h (154234 => 154235)
--- trunk/Source/WebCore/page/EditorClient.h 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebCore/page/EditorClient.h 2013-08-17 16:58:14 UTC (rev 154235)
@@ -65,7 +65,6 @@
public:
virtual ~EditorClient() { }
virtual void pageDestroyed() = 0;
- virtual void frameWillDetachPage(Frame*) = 0;
virtual bool shouldDeleteRange(Range*) = 0;
virtual bool smartInsertDeleteEnabled() = 0;
Modified: trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.h (154234 => 154235)
--- trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.h 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebKit/blackberry/WebCoreSupport/EditorClientBlackBerry.h 2013-08-17 16:58:14 UTC (rev 154235)
@@ -37,7 +37,6 @@
public:
EditorClientBlackBerry(BlackBerry::WebKit::WebPagePrivate*);
virtual void pageDestroyed();
- virtual void frameWillDetachPage(Frame*) { }
virtual bool shouldDeleteRange(Range*);
virtual bool smartInsertDeleteEnabled();
virtual bool isSelectTrailingWhitespaceEnabled();
Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h (154234 => 154235)
--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h 2013-08-17 16:58:14 UTC (rev 154235)
@@ -80,7 +80,6 @@
// from EditorClient
virtual void pageDestroyed();
- virtual void frameWillDetachPage(Frame*) { }
virtual bool shouldDeleteRange(Range*);
virtual bool smartInsertDeleteEnabled();
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h (154234 => 154235)
--- trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.h 2013-08-17 16:58:14 UTC (rev 154235)
@@ -71,7 +71,6 @@
// from EditorClient
virtual void pageDestroyed();
- virtual void frameWillDetachPage(WebCore::Frame*) { }
virtual bool shouldDeleteRange(WebCore::Range*);
virtual bool smartInsertDeleteEnabled();
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h (154234 => 154235)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.h 2013-08-17 16:58:14 UTC (rev 154235)
@@ -41,7 +41,6 @@
WebEditorClient(WebView *);
virtual ~WebEditorClient();
virtual void pageDestroyed() OVERRIDE;
- virtual void frameWillDetachPage(WebCore::Frame*) OVERRIDE { }
virtual bool isGrammarCheckingEnabled() OVERRIDE;
virtual void toggleGrammarChecking() OVERRIDE;
Modified: trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h (154234 => 154235)
--- trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebKit/qt/WebCoreSupport/EditorClientQt.h 2013-08-17 16:58:14 UTC (rev 154235)
@@ -45,7 +45,6 @@
EditorClientQt(QWebPageAdapter*);
virtual void pageDestroyed();
- virtual void frameWillDetachPage(Frame*) { }
virtual bool shouldDeleteRange(Range*);
virtual bool smartInsertDeleteEnabled();
Modified: trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h (154234 => 154235)
--- trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebEditorClient.h 2013-08-17 16:58:14 UTC (rev 154235)
@@ -41,7 +41,6 @@
~WebEditorClient();
virtual void pageDestroyed();
- virtual void frameWillDetachPage(WebCore::Frame*) { }
virtual bool isContinuousSpellCheckingEnabled();
virtual void toggleGrammarChecking();
Modified: trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h (154234 => 154235)
--- trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.h 2013-08-17 16:58:14 UTC (rev 154235)
@@ -38,7 +38,6 @@
~EditorClientWinCE();
virtual void pageDestroyed();
- virtual void frameWillDetachPage(WebCore::Frame*) { }
virtual bool shouldDeleteRange(WebCore::Range*);
virtual bool smartInsertDeleteEnabled();
Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h (154234 => 154235)
--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h 2013-08-17 16:36:15 UTC (rev 154234)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.h 2013-08-17 16:58:14 UTC (rev 154235)
@@ -42,7 +42,6 @@
private:
virtual void pageDestroyed() OVERRIDE;
- virtual void frameWillDetachPage(WebCore::Frame*) OVERRIDE { }
virtual bool shouldDeleteRange(WebCore::Range*) OVERRIDE;
virtual bool smartInsertDeleteEnabled() OVERRIDE;
