Title: [154310] trunk/Source/WebInspectorUI
- Revision
- 154310
- Author
- [email protected]
- Date
- 2013-08-19 18:31:23 -0700 (Mon, 19 Aug 2013)
Log Message
<https://webkit.org/b/118106> Web Inspector: AX: Add additional contextual labels for Error/Warnings/Logs that will be spoken for screen readers
Patch by James Craig <[email protected]> on 2013-08-19
Reviewed by Joseph Pecoraro.
Changed general console "Output" string to more specific "Error", "Warning", etc for accessibility.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/ConsoleCommandResult.js:
* UserInterface/ConsoleMessageImpl.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (154309 => 154310)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-08-20 00:53:03 UTC (rev 154309)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-08-20 01:31:23 UTC (rev 154310)
@@ -1,3 +1,15 @@
+2013-08-19 James Craig <[email protected]>
+
+ <https://webkit.org/b/118106> Web Inspector: AX: Add additional contextual labels for Error/Warnings/Logs that will be spoken for screen readers
+
+ Reviewed by Joseph Pecoraro.
+
+ Changed general console "Output" string to more specific "Error", "Warning", etc for accessibility.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/ConsoleCommandResult.js:
+ * UserInterface/ConsoleMessageImpl.js:
+
2013-08-16 James Craig <[email protected]>
<https://webkit.org/b/118105> Web Inspector: AX: Add support for ARIA tablists/tabs to inspector tabs
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (154309 => 154310)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2013-08-20 00:53:03 UTC (rev 154309)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2013-08-20 01:31:23 UTC (rev 154310)
@@ -99,6 +99,7 @@
l o c a l i z e d S t r i n g s [ " D a t a r e t u r n e d f r o m t h e d a t a b a s e i s t o o l a r g e . " ] = " D a t a r e t u r n e d f r o m t h e d a t a b a s e i s t o o l a r g e . " ;
l o c a l i z e d S t r i n g s [ " D a t a b a s e n o l o n g e r h a s e x p e c t e d v e r s i o n . " ] = " D a t a b a s e n o l o n g e r h a s e x p e c t e d v e r s i o n . " ;
l o c a l i z e d S t r i n g s [ " D a t a b a s e s " ] = " D a t a b a s e s " ;
+ l o c a l i z e d S t r i n g s [ " D e b u g : " ] = " D e b u g : " ;
l o c a l i z e d S t r i n g s [ " D e b u g g e r " ] = " D e b u g g e r " ;
l o c a l i z e d S t r i n g s [ " D e c o d e d " ] = " D e c o d e d " ;
l o c a l i z e d S t r i n g s [ " D e l e t e " ] = " D e l e t e " ;
@@ -156,6 +157,7 @@
l o c a l i z e d S t r i n g s [ " E n a b l e p o i n t t o i n s p e c t m o d e ( % s ) " ] = " E n a b l e p o i n t t o i n s p e c t m o d e ( % s ) " ;
l o c a l i z e d S t r i n g s [ " E n c o d e d " ] = " E n c o d e d " ;
l o c a l i z e d S t r i n g s [ " E n c o d i n g " ] = " E n c o d i n g " ;
+ l o c a l i z e d S t r i n g s [ " E r r o r : " ] = " E r r o r : " ;
l o c a l i z e d S t r i n g s [ " E r r o r s " ] = " E r r o r s " ;
l o c a l i z e d S t r i n g s [ " E v e n t D i s p a t c h e d " ] = " E v e n t D i s p a t c h e d " ;
l o c a l i z e d S t r i n g s [ " E v e n t L i s t e n e r s " ] = " E v e n t L i s t e n e r s " ;
@@ -224,6 +226,7 @@
l o c a l i z e d S t r i n g s [ " L o c a l V a r i a b l e s " ] = " L o c a l V a r i a b l e s " ;
l o c a l i z e d S t r i n g s [ " L o c a t e d a t % s " ] = " L o c a t e d a t % s " ;
l o c a l i z e d S t r i n g s [ " L o c a t i o n " ] = " L o c a t i o n " ;
+ l o c a l i z e d S t r i n g s [ " L o g : " ] = " L o g : " ;
l o c a l i z e d S t r i n g s [ " L o g s " ] = " L o g s " ;
l o c a l i z e d S t r i n g s [ " M I M E T y p e " ] = " M I M E T y p e " ;
l o c a l i z e d S t r i n g s [ " M a i n F r a m e " ] = " M a i n F r a m e " ;
@@ -373,6 +376,7 @@
l o c a l i z e d S t r i n g s [ " T i m e r I n s t a l l e d " ] = " T i m e r I n s t a l l e d " ;
l o c a l i z e d S t r i n g s [ " T i m e r R e m o v e d " ] = " T i m e r R e m o v e d " ;
l o c a l i z e d S t r i n g s [ " T i m e s t a m p m a r k e r a t % s " ] = " T i m e s t a m p m a r k e r a t % s " ;
+ l o c a l i z e d S t r i n g s [ " T i p : " ] = " T i p : " ;
l o c a l i z e d S t r i n g s [ " T o t a l " ] = " T o t a l " ;
l o c a l i z e d S t r i n g s [ " T o t a l n u m b e r o f r e s o u r c e s , c l i c k t o s h o w t h e R e s o u r c e s n a v i g a t i o n s i d e b a r " ] = " T o t a l n u m b e r o f r e s o u r c e s , c l i c k t o s h o w t h e R e s o u r c e s n a v i g a t i o n s i d e b a r " ;
l o c a l i z e d S t r i n g s [ " T o t a l s i z e o f a l l r e s o u r c e s , c l i c k t o s h o w t h e N e t w o r k R e q u e s t s t i m e l i n e " ] = " T o t a l s i z e o f a l l r e s o u r c e s , c l i c k t o s h o w t h e N e t w o r k R e q u e s t s t i m e l i n e " ;
@@ -385,6 +389,7 @@
l o c a l i z e d S t r i n g s [ " U s e r A g e n t S t y l e s h e e t " ] = " U s e r A g e n t S t y l e s h e e t " ;
l o c a l i z e d S t r i n g s [ " U s e r S t y l e s h e e t " ] = " U s e r S t y l e s h e e t " ;
l o c a l i z e d S t r i n g s [ " V a l u e " ] = " V a l u e " ;
+ l o c a l i z e d S t r i n g s [ " W a r n i n g : " ] = " W a r n i n g : " ;
l o c a l i z e d S t r i n g s [ " W a r n i n g s " ] = " W a r n i n g s " ;
l o c a l i z e d S t r i n g s [ " W e b I n s p e c t o r " ] = " W e b I n s p e c t o r " ;
l o c a l i z e d S t r i n g s [ " W i d t h " ] = " W i d t h " ;
Modified: trunk/Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js (154309 => 154310)
--- trunk/Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js 2013-08-20 00:53:03 UTC (rev 154309)
+++ trunk/Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js 2013-08-20 01:31:23 UTC (rev 154310)
@@ -46,7 +46,8 @@
{
var element = WebInspector.ConsoleMessageImpl.prototype.toMessageElement.call(this);
element.classList.add("console-user-command-result");
- element.setAttribute("data-labelprefix", WebInspector.UIString("Output: "));
+ if (!element.getAttribute("data-labelprefix"))
+ element.setAttribute("data-labelprefix", WebInspector.UIString("Output: "));
return element;
},
Modified: trunk/Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js (154309 => 154310)
--- trunk/Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js 2013-08-20 00:53:03 UTC (rev 154309)
+++ trunk/Source/WebInspectorUI/UserInterface/ConsoleMessageImpl.js 2013-08-20 01:31:23 UTC (rev 154310)
@@ -483,18 +483,23 @@
switch (this.level) {
case WebInspector.ConsoleMessage.MessageLevel.Tip:
element.classList.add("console-tip-level");
+ element.setAttribute("data-labelprefix", WebInspector.UIString("Tip: "));
break;
case WebInspector.ConsoleMessage.MessageLevel.Log:
element.classList.add("console-log-level");
+ element.setAttribute("data-labelprefix", WebInspector.UIString("Log: "));
break;
case WebInspector.ConsoleMessage.MessageLevel.Debug:
element.classList.add("console-debug-level");
+ element.setAttribute("data-labelprefix", WebInspector.UIString("Debug: "));
break;
case WebInspector.ConsoleMessage.MessageLevel.Warning:
element.classList.add("console-warning-level");
+ element.setAttribute("data-labelprefix", WebInspector.UIString("Warning: "));
break;
case WebInspector.ConsoleMessage.MessageLevel.Error:
element.classList.add("console-error-level");
+ element.setAttribute("data-labelprefix", WebInspector.UIString("Error: "));
break;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
