Title: [154323] trunk
- Revision
- 154323
- Author
- [email protected]
- Date
- 2013-08-20 05:47:57 -0700 (Tue, 20 Aug 2013)
Log Message
<https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and svg/custom/use-invalid-style.svg failing
Source/WebCore:
Reviewed by Andreas Kling.
* xml/XMLErrors.cpp:
(WebCore::XMLErrors::insertErrorMessageBlock): "reattach" had accidentally turned into "detach" in refactoring.
LayoutTests:
Reviewed by by Andreas Kling.
* TestExpectations: Unskip.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (154322 => 154323)
--- trunk/LayoutTests/ChangeLog 2013-08-20 11:00:14 UTC (rev 154322)
+++ trunk/LayoutTests/ChangeLog 2013-08-20 12:47:57 UTC (rev 154323)
@@ -1,5 +1,13 @@
2013-08-20 Antti Koivisto <[email protected]>
+ <https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and svg/custom/use-invalid-style.svg failing
+
+ Reviewed by by Andreas Kling.
+
+ * TestExpectations: Unskip.
+
+2013-08-20 Antti Koivisto <[email protected]>
+
<https://webkit.org/b/119969> REGRESSION (r154232): Crash on the japantimes.co.jp
Reviewed by Andreas Kling.
Modified: trunk/LayoutTests/TestExpectations (154322 => 154323)
--- trunk/LayoutTests/TestExpectations 2013-08-20 11:00:14 UTC (rev 154322)
+++ trunk/LayoutTests/TestExpectations 2013-08-20 12:47:57 UTC (rev 154323)
@@ -35,9 +35,6 @@
webkit.org/b/119094 fast/forms/color/input-color-onchange-event.html [ Crash Pass ]
-webkit.org/b/120023 svg/custom/bug78807.svg [ Failure ]
-webkit.org/b/120023 svg/custom/use-invalid-style.svg [ Failure ]
-
# This is an expected controlled crash. See webkit.org/b/119976 for a better solution.
fast/css/giant-stylesheet-crash.html [ Crash ]
Modified: trunk/Source/WebCore/ChangeLog (154322 => 154323)
--- trunk/Source/WebCore/ChangeLog 2013-08-20 11:00:14 UTC (rev 154322)
+++ trunk/Source/WebCore/ChangeLog 2013-08-20 12:47:57 UTC (rev 154323)
@@ -1,5 +1,14 @@
2013-08-20 Antti Koivisto <[email protected]>
+ <https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and svg/custom/use-invalid-style.svg failing
+
+ Reviewed by Andreas Kling.
+
+ * xml/XMLErrors.cpp:
+ (WebCore::XMLErrors::insertErrorMessageBlock): "reattach" had accidentally turned into "detach" in refactoring.
+
+2013-08-20 Antti Koivisto <[email protected]>
+
<https://webkit.org/b/119969> REGRESSION (r154232): Crash on the japantimes.co.jp
Reviewed by Andreas Kling.
Modified: trunk/Source/WebCore/xml/XMLErrors.cpp (154322 => 154323)
--- trunk/Source/WebCore/xml/XMLErrors.cpp 2013-08-20 11:00:14 UTC (rev 154322)
+++ trunk/Source/WebCore/xml/XMLErrors.cpp 2013-08-20 12:47:57 UTC (rev 154323)
@@ -147,7 +147,7 @@
if (m_document->attached())
// In general, rootElement shouldn't be attached right now, but it will be if there is a style element
// in the SVG content.
- Style::detachRenderTree(rootElement.get());
+ Style::reattachRenderTree(rootElement.get());
documentElement = body.get();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
