Title: [154328] trunk
Revision
154328
Author
[email protected]
Date
2013-08-20 08:52:27 -0700 (Tue, 20 Aug 2013)

Log Message

<https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings

Reviewed by Martin Robinson.

Source/WebCore:

No new tests, these are just stubs for the DOM bindings API.

* bindings/gobject/WebKitDOMCustom.cpp:
(webkit_dom_bar_info_get_property):
(webkit_dom_bar_info_class_init):
(webkit_dom_bar_info_init):
(webkit_dom_bar_info_get_visible):
(webkit_dom_console_get_memory):
(webkit_dom_css_style_declaration_get_property_css_value):
(webkit_dom_document_get_webkit_hidden):
(webkit_dom_document_get_webkit_visibility_state):
(webkit_dom_html_document_open):
(webkit_dom_html_element_set_item_id):
(webkit_dom_html_element_get_item_id):
(webkit_dom_html_element_get_item_ref):
(webkit_dom_html_element_get_item_prop):
(webkit_dom_html_element_set_item_scope):
(webkit_dom_html_element_get_item_scope):
(webkit_dom_html_element_get_item_type):
(webkit_dom_html_properties_collection_get_property):
(webkit_dom_html_properties_collection_class_init):
(webkit_dom_html_properties_collection_init):
(webkit_dom_html_properties_collection_item):
(webkit_dom_html_properties_collection_named_item):
(webkit_dom_html_properties_collection_get_length):
(webkit_dom_html_properties_collection_get_names):
(webkit_dom_node_get_attributes):
(webkit_dom_node_has_attributes):
(webkit_dom_memory_info_get_property):
(webkit_dom_memory_info_class_init):
(webkit_dom_memory_info_init):
(webkit_dom_memory_info_get_total_js_heap_size):
(webkit_dom_memory_info_get_used_js_heap_size):
(webkit_dom_memory_info_get_js_heap_size_limit):
(webkit_dom_micro_data_item_value_class_init):
(webkit_dom_micro_data_item_value_init):
(webkit_dom_performance_get_memory):
(webkit_dom_property_node_list_get_property):
(webkit_dom_property_node_list_class_init):
(webkit_dom_property_node_list_init):
(webkit_dom_property_node_list_item):
(webkit_dom_property_node_list_get_length):
* bindings/gobject/WebKitDOMCustom.h:

Tools:

* Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
from naming/enum_casing rules, since it needs to provide GObject-style APIs.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (154327 => 154328)


--- trunk/Source/WebCore/ChangeLog	2013-08-20 15:27:41 UTC (rev 154327)
+++ trunk/Source/WebCore/ChangeLog	2013-08-20 15:52:27 UTC (rev 154328)
@@ -1,3 +1,53 @@
+2013-08-19  Gustavo Noronha Silva  <[email protected]>
+
+        <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
+
+        Reviewed by Martin Robinson.
+
+        No new tests, these are just stubs for the DOM bindings API.
+
+        * bindings/gobject/WebKitDOMCustom.cpp:
+        (webkit_dom_bar_info_get_property):
+        (webkit_dom_bar_info_class_init):
+        (webkit_dom_bar_info_init):
+        (webkit_dom_bar_info_get_visible):
+        (webkit_dom_console_get_memory):
+        (webkit_dom_css_style_declaration_get_property_css_value):
+        (webkit_dom_document_get_webkit_hidden):
+        (webkit_dom_document_get_webkit_visibility_state):
+        (webkit_dom_html_document_open):
+        (webkit_dom_html_element_set_item_id):
+        (webkit_dom_html_element_get_item_id):
+        (webkit_dom_html_element_get_item_ref):
+        (webkit_dom_html_element_get_item_prop):
+        (webkit_dom_html_element_set_item_scope):
+        (webkit_dom_html_element_get_item_scope):
+        (webkit_dom_html_element_get_item_type):
+        (webkit_dom_html_properties_collection_get_property):
+        (webkit_dom_html_properties_collection_class_init):
+        (webkit_dom_html_properties_collection_init):
+        (webkit_dom_html_properties_collection_item):
+        (webkit_dom_html_properties_collection_named_item):
+        (webkit_dom_html_properties_collection_get_length):
+        (webkit_dom_html_properties_collection_get_names):
+        (webkit_dom_node_get_attributes):
+        (webkit_dom_node_has_attributes):
+        (webkit_dom_memory_info_get_property):
+        (webkit_dom_memory_info_class_init):
+        (webkit_dom_memory_info_init):
+        (webkit_dom_memory_info_get_total_js_heap_size):
+        (webkit_dom_memory_info_get_used_js_heap_size):
+        (webkit_dom_memory_info_get_js_heap_size_limit):
+        (webkit_dom_micro_data_item_value_class_init):
+        (webkit_dom_micro_data_item_value_init):
+        (webkit_dom_performance_get_memory):
+        (webkit_dom_property_node_list_get_property):
+        (webkit_dom_property_node_list_class_init):
+        (webkit_dom_property_node_list_init):
+        (webkit_dom_property_node_list_item):
+        (webkit_dom_property_node_list_get_length):
+        * bindings/gobject/WebKitDOMCustom.h:
+
 2013-08-20  Antti Koivisto  <[email protected]>
 
         <https://webkit.org/b/120017> Remove NodeRenderingTraversal::ParentDetails

Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp (154327 => 154328)


--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp	2013-08-20 15:27:41 UTC (rev 154327)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp	2013-08-20 15:52:27 UTC (rev 154328)
@@ -20,11 +20,16 @@
 #include "WebKitDOMCustom.h"
 
 #include "WebKitDOMBlob.h"
+#include "WebKitDOMDOMStringList.h"
+#include "WebKitDOMHTMLCollection.h"
 #include "WebKitDOMHTMLFormElement.h"
 #include "WebKitDOMHTMLInputElement.h"
 #include "WebKitDOMHTMLInputElementPrivate.h"
 #include "WebKitDOMHTMLTextAreaElement.h"
 #include "WebKitDOMHTMLTextAreaElementPrivate.h"
+#include "WebKitDOMNodeList.h"
+#include "WebKitDOMObject.h"
+#include "WebKitDOMPrivate.h"
 #include "WebKitDOMWebKitNamedFlow.h"
 
 using namespace WebKit;
@@ -44,64 +49,479 @@
 }
 
 /* Compatibility */
-WebKitDOMBlob*
-webkit_dom_blob_webkit_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type)
+WebKitDOMBlob* webkit_dom_blob_webkit_slice(WebKitDOMBlob* self, gint64 start, gint64 end, const gchar* content_type)
 {
     return webkit_dom_blob_slice(self, start, end, content_type);
 }
 
-gchar*
-webkit_dom_html_element_get_class_name(WebKitDOMHTMLElement* element)
+gchar* webkit_dom_html_element_get_class_name(WebKitDOMHTMLElement* element)
 {
     return webkit_dom_element_get_class_name(WEBKIT_DOM_ELEMENT(element));
 }
 
-void
-webkit_dom_html_element_set_class_name(WebKitDOMHTMLElement* element, const gchar* value)
+void webkit_dom_html_element_set_class_name(WebKitDOMHTMLElement* element, const gchar* value)
 {
     webkit_dom_element_set_class_name(WEBKIT_DOM_ELEMENT(element), value);
 }
 
-gboolean
-webkit_dom_webkit_named_flow_get_overflow(WebKitDOMWebKitNamedFlow* flow)
+gboolean webkit_dom_webkit_named_flow_get_overflow(WebKitDOMWebKitNamedFlow* flow)
 {
     g_warning("The WebKitDOMWebKitNamedFlow::overflow property has been renamed to WebKitDOMWebKitNamedFlow::overset. Please update your code to use the new name.");
     return webkit_dom_webkit_named_flow_get_overset(flow);
 }
 
-WebKitDOMDOMTokenList*
-webkit_dom_html_element_get_class_list(WebKitDOMHTMLElement* element)
+WebKitDOMDOMTokenList* webkit_dom_html_element_get_class_list(WebKitDOMHTMLElement* element)
 {
     return webkit_dom_element_get_class_list(WEBKIT_DOM_ELEMENT(element));
 }
 
-gchar*
-webkit_dom_element_get_webkit_region_overflow(WebKitDOMElement* element)
+gchar* webkit_dom_element_get_webkit_region_overflow(WebKitDOMElement* element)
 {
     return webkit_dom_element_get_webkit_region_overset(element);
 }
 
-WebKitDOMNodeList*
-webkit_dom_webkit_named_flow_get_content_nodes(WebKitDOMWebKitNamedFlow* namedFlow)
+WebKitDOMNodeList* webkit_dom_webkit_named_flow_get_content_nodes(WebKitDOMWebKitNamedFlow* namedFlow)
 {
     return webkit_dom_webkit_named_flow_get_content(namedFlow);
 
 }
 
-WebKitDOMNodeList*
-webkit_dom_webkit_named_flow_get_regions_by_content_node(WebKitDOMWebKitNamedFlow* namedFlow, WebKitDOMNode* contentNode)
+WebKitDOMNodeList* webkit_dom_webkit_named_flow_get_regions_by_content_node(WebKitDOMWebKitNamedFlow* namedFlow, WebKitDOMNode* contentNode)
 {
     return webkit_dom_webkit_named_flow_get_regions_by_content(namedFlow, contentNode);
 }
 
-void
-webkit_dom_html_form_element_dispatch_form_change(WebKitDOMHTMLFormElement* self)
+void webkit_dom_html_form_element_dispatch_form_change(WebKitDOMHTMLFormElement* self)
 {
     g_warning("The onformchange functionality has been removed from the DOM spec, this function does nothing.");
 }
 
-void
-webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement* self)
+void webkit_dom_html_form_element_dispatch_form_input(WebKitDOMHTMLFormElement* self)
 {
     g_warning("The onforminput functionality has been removed from the DOM spec, this function does nothing.");
 }
+
+// WebKitDOMBarInfo
+
+typedef struct _WebKitDOMBarInfo {
+    WebKitDOMObject parent_instance;
+} WebKitDOMBarInfo;
+
+typedef struct _WebKitDOMBarInfoClass {
+    WebKitDOMObjectClass parent_class;
+} WebKitDOMBarInfoClass;
+
+G_DEFINE_TYPE(WebKitDOMBarInfo, webkit_dom_bar_info, WEBKIT_TYPE_DOM_OBJECT)
+
+typedef enum {
+    PROP_0,
+    PROP_VISIBLE,
+} WebKitDOMBarInfoProperties;
+
+static void webkit_dom_bar_info_get_property(GObject* object, guint propertyId, GValue* value, GParamSpec* pspec)
+{
+    switch (propertyId) {
+    case PROP_VISIBLE: {
+        WEBKIT_WARN_FEATURE_NOT_PRESENT("BarInfo")
+        g_value_set_boolean(value, FALSE);
+        break;
+    }
+    default:
+        G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propertyId, pspec);
+        break;
+    }
+}
+
+static void webkit_dom_bar_info_class_init(WebKitDOMBarInfoClass* requestClass)
+{
+    GObjectClass* gobjectClass = G_OBJECT_CLASS(requestClass);
+    gobjectClass->get_property = webkit_dom_bar_info_get_property;
+
+    g_object_class_install_property(gobjectClass,
+        PROP_VISIBLE,
+        g_param_spec_boolean("visible",
+            "bar_info_visible - removed from WebKit, does nothing",
+            "read-only  gboolean BarInfo.visible - removed from WebKit, does nothing",
+            FALSE,
+            WEBKIT_PARAM_READABLE));
+}
+
+static void webkit_dom_bar_info_init(WebKitDOMBarInfo*)
+{
+}
+
+gboolean webkit_dom_bar_info_get_visible(void*)
+{
+    g_warning("The BarInfo type has been removed from the DOM spec, this function does nothing.");
+    return FALSE;
+}
+
+// WebKitDOMConsole
+
+void* webkit_dom_console_get_memory(WebKitDOMConsole*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+// WebKitDOMCSSStyleDeclaration
+
+WebKitDOMCSSValue* webkit_dom_css_style_declaration_get_property_css_value(WebKitDOMCSSStyleDeclaration*, const gchar*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+// WebKitDOMDocument
+
+gboolean webkit_dom_document_get_webkit_hidden(WebKitDOMDocument*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+    return FALSE;
+}
+
+gchar* webkit_dom_document_get_webkit_visibility_state(WebKitDOMDocument*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+    return g_strdup("");
+}
+
+// WebKitDOMHTMLDocument
+
+void webkit_dom_html_document_open(WebKitDOMHTMLDocument*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+}
+
+// WebKitDOMHTMLElement
+
+void webkit_dom_html_element_set_item_id(WebKitDOMHTMLElement*, const gchar*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+}
+
+gchar* webkit_dom_html_element_get_item_id(WebKitDOMHTMLElement*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+    return g_strdup("");
+}
+
+WebKitDOMDOMSettableTokenList* webkit_dom_html_element_get_item_ref(WebKitDOMHTMLElement*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+WebKitDOMDOMSettableTokenList* webkit_dom_html_element_get_item_prop(WebKitDOMHTMLElement*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+void webkit_dom_html_element_set_item_scope(WebKitDOMHTMLElement*, gboolean)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+}
+
+gboolean webkit_dom_html_element_get_item_scope(WebKitDOMHTMLElement*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+    return FALSE;
+}
+
+void* webkit_dom_html_element_get_item_type(WebKitDOMHTMLElement*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+}
+
+// WebKitDOMHTMLPropertiesCollection
+
+typedef struct _WebKitDOMHTMLPropertiesCollection {
+    WebKitDOMHTMLCollection parent_instance;
+} WebKitDOMHTMLPropertiesCollection;
+
+typedef struct _WebKitDOMHTMLPropertiesCollectionClass {
+    WebKitDOMHTMLCollectionClass parent_class;
+} WebKitDOMHTMLPropertiesCollectionClass;
+
+G_DEFINE_TYPE(WebKitDOMHTMLPropertiesCollection, webkit_dom_html_properties_collection, WEBKIT_TYPE_DOM_HTML_COLLECTION)
+
+enum {
+    HTML_PROPERTIES_COLLECTION_PROP_0,
+    HTML_PROPERTIES_COLLECTION_PROP_LENGTH,
+    HTML_PROPERTIES_COLLECTION_PROP_NAMES,
+};
+
+static void webkit_dom_html_properties_collection_get_property(GObject* object, guint propertyId, GValue* value, GParamSpec* pspec)
+{
+    switch (propertyId) {
+    case HTML_PROPERTIES_COLLECTION_PROP_LENGTH: {
+        WEBKIT_WARN_FEATURE_NOT_PRESENT("Microdata")
+        break;
+    }
+    case HTML_PROPERTIES_COLLECTION_PROP_NAMES: {
+        WEBKIT_WARN_FEATURE_NOT_PRESENT("Microdata")
+        break;
+    }
+    default:
+        G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propertyId, pspec);
+        break;
+    }
+}
+
+static void webkit_dom_html_properties_collection_class_init(WebKitDOMHTMLPropertiesCollectionClass* requestClass)
+{
+    GObjectClass* gobjectClass = G_OBJECT_CLASS(requestClass);
+    gobjectClass->get_property = webkit_dom_html_properties_collection_get_property;
+
+    g_object_class_install_property(gobjectClass,
+        HTML_PROPERTIES_COLLECTION_PROP_LENGTH,
+        g_param_spec_ulong("length",
+            "html_properties_collection_length - removed from WebKit, does nothing",
+            "read-only  gulong HTMLPropertiesCollection.length - removed from WebKit, does nothing",
+            0,
+            G_MAXULONG,
+            0,
+            WEBKIT_PARAM_READABLE));
+
+    g_object_class_install_property(gobjectClass,
+        HTML_PROPERTIES_COLLECTION_PROP_NAMES,
+        g_param_spec_object("names",
+            "html_properties_collection_names - removed from WebKit, does nothing",
+            "read-only  WebKitDOMDOMStringList* HTMLPropertiesCollection.names - removed from WebKit, does nothing",
+            WEBKIT_TYPE_DOM_DOM_STRING_LIST,
+            WEBKIT_PARAM_READABLE));
+}
+
+static void webkit_dom_html_properties_collection_init(WebKitDOMHTMLPropertiesCollection* request)
+{
+}
+
+WebKitDOMNode* webkit_dom_html_properties_collection_item(void*, gulong)
+{
+    g_warning("%s: the PropertiesCollection object has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+void* webkit_dom_html_properties_collection_named_item(void*, const gchar*)
+{
+    g_warning("%s: the PropertiesCollection object has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+gulong webkit_dom_html_properties_collection_get_length(void*)
+{
+    g_warning("%s: the PropertiesCollection object has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+WebKitDOMDOMStringList* webkit_dom_html_properties_collection_get_names(void*)
+{
+    g_warning("%s: the PropertiesCollection object has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+// WebKitDOMNode
+
+WebKitDOMNamedNodeMap* webkit_dom_node_get_attributes(WebKitDOMNode*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+gboolean webkit_dom_node_has_attributes(WebKitDOMNode*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+    return FALSE;
+}
+
+// WebKitDOMMemoryInfo
+
+typedef struct _WebKitDOMMemoryInfo {
+    WebKitDOMObject parent_instance;
+} WebKitDOMMemoryInfo;
+
+typedef struct _WebKitDOMMemoryInfoClass {
+    WebKitDOMObjectClass parent_class;
+} WebKitDOMMemoryInfoClass;
+
+
+G_DEFINE_TYPE(WebKitDOMMemoryInfo, webkit_dom_memory_info, WEBKIT_TYPE_DOM_OBJECT)
+
+enum {
+    DOM_MEMORY_PROP_0,
+    DOM_MEMORY_PROP_TOTAL_JS_HEAP_SIZE,
+    DOM_MEMORY_PROP_USED_JS_HEAP_SIZE,
+    DOM_MEMORY_PROP_JS_HEAP_SIZE_LIMIT,
+};
+
+static void webkit_dom_memory_info_get_property(GObject* object, guint propertyId, GValue* value, GParamSpec* pspec)
+{
+    switch (propertyId) {
+    case DOM_MEMORY_PROP_TOTAL_JS_HEAP_SIZE: {
+        g_value_set_ulong(value, 0);
+        WEBKIT_WARN_FEATURE_NOT_PRESENT("MemoryInfo")
+        break;
+    }
+    case DOM_MEMORY_PROP_USED_JS_HEAP_SIZE: {
+        g_value_set_ulong(value, 0);
+        WEBKIT_WARN_FEATURE_NOT_PRESENT("MemoryInfo")
+        break;
+    }
+    case DOM_MEMORY_PROP_JS_HEAP_SIZE_LIMIT: {
+        g_value_set_ulong(value, 0);
+        WEBKIT_WARN_FEATURE_NOT_PRESENT("MemoryInfo")
+        break;
+    }
+    default:
+        G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propertyId, pspec);
+        break;
+    }
+}
+
+static void webkit_dom_memory_info_class_init(WebKitDOMMemoryInfoClass* requestClass)
+{
+    GObjectClass* gobjectClass = G_OBJECT_CLASS(requestClass);
+    gobjectClass->get_property = webkit_dom_memory_info_get_property;
+
+    g_object_class_install_property(gobjectClass,
+        DOM_MEMORY_PROP_TOTAL_JS_HEAP_SIZE,
+        g_param_spec_ulong("total-js-heap-size",
+            "memory_info_total-js-heap-size - removed from WebKit, does nothing",
+            "read-only  gulong MemoryInfo.total-js-heap-size - removed from WebKit, does nothing",
+            0,
+            G_MAXULONG,
+            0,
+            WEBKIT_PARAM_READABLE));
+    g_object_class_install_property(gobjectClass,
+        DOM_MEMORY_PROP_USED_JS_HEAP_SIZE,
+        g_param_spec_ulong("used-js-heap-size",
+            "memory_info_used-js-heap-size - removed from WebKit, does nothing",
+            "read-only  gulong MemoryInfo.used-js-heap-size - removed from WebKit, does nothing",
+            0,
+            G_MAXULONG,
+            0,
+            WEBKIT_PARAM_READABLE));
+    g_object_class_install_property(gobjectClass,
+        DOM_MEMORY_PROP_JS_HEAP_SIZE_LIMIT,
+        g_param_spec_ulong("js-heap-size-limit",
+            "memory_info_js-heap-size-limit - removed from WebKit, does nothing",
+            "read-only  gulong MemoryInfo.js-heap-size-limit - removed from WebKit, does nothing",
+            0,
+            G_MAXULONG,
+            0,
+            WEBKIT_PARAM_READABLE));
+}
+
+static void webkit_dom_memory_info_init(WebKitDOMMemoryInfo*)
+{
+}
+
+gulong webkit_dom_memory_info_get_total_js_heap_size(void*)
+{
+    g_warning("%s: the MemoryInfo object has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+gulong webkit_dom_memory_info_get_used_js_heap_size(void*)
+{
+    g_warning("%s: the MemoryInfo object has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+gulong webkit_dom_memory_info_get_js_heap_size_limit(void*)
+{
+    g_warning("%s: the MemoryInfo object has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+// WebKitDOMMicroDataItemValue
+
+typedef struct _WebKitDOMMicroDataItemValue {
+    WebKitDOMObject parent_instance;
+} WebKitDOMMicroDataItemValue;
+
+typedef struct _WebKitDOMMicroDataItemValueClass {
+    WebKitDOMObjectClass parent_class;
+} WebKitDOMMicroDataItemValueClass;
+
+G_DEFINE_TYPE(WebKitDOMMicroDataItemValue, webkit_dom_micro_data_item_value, WEBKIT_TYPE_DOM_OBJECT)
+
+static void webkit_dom_micro_data_item_value_class_init(WebKitDOMMicroDataItemValueClass*)
+{
+}
+
+static void webkit_dom_micro_data_item_value_init(WebKitDOMMicroDataItemValue*)
+{
+}
+
+// WebKitDOMPerformance
+
+void* webkit_dom_performance_get_memory(WebKitDOMPerformance*)
+{
+    g_warning("%s: this functionality has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+// WebKitDOMPropertyNodeList
+
+typedef struct _WebKitDOMPropertyNodeList {
+    WebKitDOMNodeList parent_instance;
+} WebKitDOMPropertyNodeList;
+
+typedef struct _WebKitDOMPropertyNodeListClass {
+    WebKitDOMNodeListClass parent_class;
+} WebKitDOMPropertyNodeListClass;
+
+G_DEFINE_TYPE(WebKitDOMPropertyNodeList, webkit_dom_property_node_list, WEBKIT_TYPE_DOM_NODE_LIST)
+
+enum {
+    PROPERTY_NODE_LIST_PROP_0,
+    PROPERTY_NODE_LIST_PROP_LENGTH,
+};
+
+static void webkit_dom_property_node_list_get_property(GObject* object, guint propertyId, GValue* value, GParamSpec* pspec)
+{
+    switch (propertyId) {
+    case PROPERTY_NODE_LIST_PROP_LENGTH: {
+        g_value_set_ulong(value, 0);
+        WEBKIT_WARN_FEATURE_NOT_PRESENT("Microdata")
+        break;
+    }
+    default:
+        G_OBJECT_WARN_INVALID_PROPERTY_ID(object, propertyId, pspec);
+        break;
+    }
+}
+
+static void webkit_dom_property_node_list_class_init(WebKitDOMPropertyNodeListClass* requestClass)
+{
+    GObjectClass* gobjectClass = G_OBJECT_CLASS(requestClass);
+    gobjectClass->get_property = webkit_dom_property_node_list_get_property;
+
+    g_object_class_install_property(gobjectClass,
+        PROPERTY_NODE_LIST_PROP_LENGTH,
+        g_param_spec_ulong("length",
+            "property_node_list_length - removed from WebKit, does nothing",
+            "read-only  gulong PropertyNodeList.length - removed from WebKit, does nothing",
+            0,
+            G_MAXULONG,
+            0,
+            WEBKIT_PARAM_READABLE));
+}
+
+static void webkit_dom_property_node_list_init(WebKitDOMPropertyNodeList*)
+{
+}
+
+WebKitDOMNode* webkit_dom_property_node_list_item(void*, gulong)
+{
+    g_warning("%s: the PropertyNodeList object has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}
+
+gulong webkit_dom_property_node_list_get_length(void*)
+{
+    g_warning("%s: the PropertyNodeList object has been removed from WebKit, this function does nothing.", __func__);
+    return 0;
+}

Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h (154327 => 154328)


--- trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2013-08-20 15:27:41 UTC (rev 154327)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMCustom.h	2013-08-20 15:52:27 UTC (rev 154328)
@@ -19,6 +19,7 @@
 #ifndef WebKitDOMCustom_h
 #define WebKitDOMCustom_h
 
+#include <glib-object.h>
 #include <glib.h>
 #include <webkitdom/webkitdomdefines.h>
 
@@ -126,6 +127,295 @@
  */
 WEBKIT_API WebKitDOMNodeList* webkit_dom_webkit_named_flow_get_regions_by_content_node(WebKitDOMWebKitNamedFlow* flow, WebKitDOMNode* content_node);
 
+WEBKIT_API GType webkit_dom_bar_info_get_type(void);
+
+/**
+ * webkit_dom_bar_info_get_visible:
+ * @self: A #WebKitDOMBarInfo
+ *
+ * The BarInfo type has been removed from the DOM spec, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gboolean webkit_dom_bar_info_get_visible(void* self);
+
+/**
+ * webkit_dom_console_get_memory:
+ * @self: A #WebKitDOMConsole
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns: (transfer none):
+ *
+**/
+WEBKIT_API void* webkit_dom_console_get_memory(WebKitDOMConsole* self);
+
+/**
+ * webkit_dom_css_style_declaration_get_property_css_value:
+ * @self: A #WebKitDOMCSSStyleDeclaration
+ * @propertyName: A #gchar
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns: (transfer none):
+ *
+**/
+WEBKIT_API WebKitDOMCSSValue* webkit_dom_css_style_declaration_get_property_css_value(WebKitDOMCSSStyleDeclaration* self, const gchar* propertyName);
+
+/**
+ * webkit_dom_document_get_webkit_hidden:
+ * @self: A #WebKitDOMDocument
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gboolean webkit_dom_document_get_webkit_hidden(WebKitDOMDocument* self);
+
+/**
+ * webkit_dom_document_get_webkit_visibility_state:
+ * @self: A #WebKitDOMDocument
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gchar* webkit_dom_document_get_webkit_visibility_state(WebKitDOMDocument* self);
+
+/**
+ * webkit_dom_html_document_open:
+ * @self: A #WebKitDOMHTMLDocument
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API void webkit_dom_html_document_open(WebKitDOMHTMLDocument* self);
+
+/**
+ * webkit_dom_html_element_set_item_id:
+ * @self: A #WebKitDOMHTMLElement
+ * @value: A #gchar
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API void webkit_dom_html_element_set_item_id(WebKitDOMHTMLElement* self, const gchar* value);
+
+/**
+ * webkit_dom_html_element_get_item_id:
+ * @self: A #WebKitDOMHTMLElement
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gchar* webkit_dom_html_element_get_item_id(WebKitDOMHTMLElement* self);
+
+/**
+ * webkit_dom_html_element_get_item_ref:
+ * @self: A #WebKitDOMHTMLElement
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns: (transfer none):
+ *
+**/
+WEBKIT_API WebKitDOMDOMSettableTokenList* webkit_dom_html_element_get_item_ref(WebKitDOMHTMLElement* self);
+
+/**
+ * webkit_dom_html_element_get_item_prop:
+ * @self: A #WebKitDOMHTMLElement
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns: (transfer none):
+ *
+**/
+WEBKIT_API WebKitDOMDOMSettableTokenList* webkit_dom_html_element_get_item_prop(WebKitDOMHTMLElement* self);
+
+/**
+ * webkit_dom_html_element_set_item_scope:
+ * @self: A #WebKitDOMHTMLElement
+ * @value: A #gboolean
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API void webkit_dom_html_element_set_item_scope(WebKitDOMHTMLElement* self, gboolean value);
+
+/**
+ * webkit_dom_html_element_get_item_scope:
+ * @self: A #WebKitDOMHTMLElement
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gboolean webkit_dom_html_element_get_item_scope(WebKitDOMHTMLElement* self);
+
+/**
+ * webkit_dom_html_element_get_item_type:
+ * @self: A #WebKitDOMHTMLElement
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns: (transfer none):
+ *
+**/
+WEBKIT_API void* webkit_dom_html_element_get_item_type(WebKitDOMHTMLElement* self);
+
+WEBKIT_API GType webkit_dom_html_properties_collection_get_type(void);
+
+/**
+ * webkit_dom_html_properties_collection_item:
+ * @self: A #WebKitDOMHTMLPropertiesCollection
+ * @index: A #gulong
+ *
+ * The PropertiesCollection object has been removed from WebKit, this function does nothing.
+ *
+ * Returns: (transfer none):
+ *
+**/
+WEBKIT_API WebKitDOMNode* webkit_dom_html_properties_collection_item(void* self, gulong index);
+
+/**
+ * webkit_dom_html_properties_collection_named_item:
+ * @self: A #WebKitDOMHTMLPropertiesCollection
+ * @name: A #gchar
+ *
+ * The PropertiesCollection object has been removed from WebKit, this function does nothing.
+ *
+ * Returns: (transfer none):
+ *
+**/
+WEBKIT_API void* webkit_dom_html_properties_collection_named_item(void* self, const gchar* name);
+
+/**
+ * webkit_dom_html_properties_collection_get_length:
+ * @self: A #WebKitDOMHTMLPropertiesCollection
+ *
+ * The PropertiesCollection object has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gulong webkit_dom_html_properties_collection_get_length(void* self);
+
+/**
+ * webkit_dom_html_properties_collection_get_names:
+ * @self: A #WebKitDOMHTMLPropertiesCollection
+ *
+ * The PropertiesCollection object has been removed from WebKit, this function does nothing.
+ *
+ * Returns: (transfer none):
+ *
+**/
+WEBKIT_API WebKitDOMDOMStringList* webkit_dom_html_properties_collection_get_names(void* self);
+
+/**
+ * webkit_dom_node_get_attributes:
+ * @self: A #WebKitDOMNode
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns: (transfer none):
+ *
+**/
+WEBKIT_API WebKitDOMNamedNodeMap* webkit_dom_node_get_attributes(WebKitDOMNode* self);
+
+/**
+ * webkit_dom_node_has_attributes:
+ * @self: A #WebKitDOMNode
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gboolean webkit_dom_node_has_attributes(WebKitDOMNode* self);
+
+WEBKIT_API GType webkit_dom_memory_info_get_type(void);
+
+/**
+ * webkit_dom_memory_info_get_total_js_heap_size:
+ * @self: A #WebKitDOMMemoryInfo
+ *
+ * The MemoryInfo object has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gulong webkit_dom_memory_info_get_total_js_heap_size(void* self);
+
+/**
+ * webkit_dom_memory_info_get_used_js_heap_size:
+ * @self: A #WebKitDOMMemoryInfo
+ *
+ * The MemoryInfo object has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gulong webkit_dom_memory_info_get_used_js_heap_size(void* self);
+
+/**
+ * webkit_dom_memory_info_get_js_heap_size_limit:
+ * @self: A #WebKitDOMMemoryInfo
+ *
+ * The MemoryInfo object has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gulong webkit_dom_memory_info_get_js_heap_size_limit(void* self);
+
+WEBKIT_API GType webkit_dom_micro_data_item_value_get_type(void);
+
+/**
+ * webkit_dom_performance_get_memory:
+ * @self: A #WebKitDOMPerformance
+ *
+ * This functionality has been removed from WebKit, this function does nothing.
+ *
+ * Returns: (transfer none):
+ *
+**/
+WEBKIT_API void* webkit_dom_performance_get_memory(WebKitDOMPerformance* self);
+
+WEBKIT_API GType webkit_dom_property_node_list_get_type(void);
+
+/**
+ * webkit_dom_property_node_list_item:
+ * @self: A #WebKitDOMPropertyNodeList
+ * @index: A #gulong
+ *
+ * The PropertyNodeList object has been removed from WebKit, this function does nothing.
+ *
+ * Returns: (transfer none):
+ *
+**/
+WEBKIT_API WebKitDOMNode* webkit_dom_property_node_list_item(void* self, gulong index);
+
+/**
+ * webkit_dom_property_node_list_get_length:
+ * @self: A #WebKitDOMPropertyNodeList
+ *
+ * The PropertyNodeList object has been removed from WebKit, this function does nothing.
+ *
+ * Returns:
+ *
+**/
+WEBKIT_API gulong webkit_dom_property_node_list_get_length(void* self);
+
 G_END_DECLS
 
 #endif

Modified: trunk/Tools/ChangeLog (154327 => 154328)


--- trunk/Tools/ChangeLog	2013-08-20 15:27:41 UTC (rev 154327)
+++ trunk/Tools/ChangeLog	2013-08-20 15:52:27 UTC (rev 154328)
@@ -1,3 +1,12 @@
+2013-08-19  Gustavo Noronha Silva  <[email protected]>
+
+        <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
+
+        Reviewed by Martin Robinson.
+
+        * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
+        from naming/enum_casing rules, since it needs to provide GObject-style APIs.
+
 2013-08-20  Anton Obzhirov  <[email protected]>
 
         <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser

Modified: trunk/Tools/Scripts/webkitpy/style/checker.py (154327 => 154328)


--- trunk/Tools/Scripts/webkitpy/style/checker.py	2013-08-20 15:27:41 UTC (rev 154327)
+++ trunk/Tools/Scripts/webkitpy/style/checker.py	2013-08-20 15:52:27 UTC (rev 154328)
@@ -238,15 +238,16 @@
       "-whitespace/declaration"]),
     ([# These files define GObjects, which implies some definitions of
       # variables and functions containing underscores.
-      "Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.cpp",
-      "Source/WebCore/platform/graphics/clutter/GraphicsLayerActor.h",
+      "Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp",
+      "Source/WebCore/bindings/gobject/WebKitDOMCustom.h",
       "Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp",
       "Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp",
       "Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp",
       "Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp",
       "Source/WebCore/platform/network/soup/ProxyResolverSoup.cpp",
       "Source/WebCore/platform/network/soup/ProxyResolverSoup.h"],
-     ["-readability/naming"]),
+     ["-readability/naming",
+      "-readability/enum_casing"]),
 
     # For third-party Python code, keep only the following checks--
     #
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to