Title: [154353] trunk/Source/WebCore
- Revision
- 154353
- Author
- [email protected]
- Date
- 2013-08-20 13:23:35 -0700 (Tue, 20 Aug 2013)
Log Message
<https://webkit.org/b/105988> [Mac] Some inspector tests intermittently assert in InspectorOverlay::paint
<rdar://problem/12958038>
Reviewed by Joseph Pecoraro.
Update the inspector overlay's layout before painting, if it is stale.
No new tests; fixes an intermittent assertion failure in some existing tests.
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::paint):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (154352 => 154353)
--- trunk/Source/WebCore/ChangeLog 2013-08-20 19:41:02 UTC (rev 154352)
+++ trunk/Source/WebCore/ChangeLog 2013-08-20 20:23:35 UTC (rev 154353)
@@ -1,3 +1,17 @@
+2013-08-20 Tim Horton <[email protected]>
+
+ <https://webkit.org/b/105988> [Mac] Some inspector tests intermittently assert in InspectorOverlay::paint
+ <rdar://problem/12958038>
+
+ Reviewed by Joseph Pecoraro.
+
+ Update the inspector overlay's layout before painting, if it is stale.
+
+ No new tests; fixes an intermittent assertion failure in some existing tests.
+
+ * inspector/InspectorOverlay.cpp:
+ (WebCore::InspectorOverlay::paint):
+
2013-08-20 Daniel Bates <[email protected]>
Build fix after <http://trac.webkit.org/changeset/154260> (https://webkit.org/b/119949);
Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (154352 => 154353)
--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2013-08-20 19:41:02 UTC (rev 154352)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2013-08-20 20:23:35 UTC (rev 154353)
@@ -209,7 +209,7 @@
return;
GraphicsContextStateSaver stateSaver(context);
FrameView* view = overlayPage()->mainFrame()->view();
- ASSERT(!view->needsLayout());
+ view->updateLayoutAndStyleIfNeededRecursive();
view->paint(&context, IntRect(0, 0, view->width(), view->height()));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
