Title: [154380] trunk/Source/WebKit/gtk
Revision
154380
Author
[email protected]
Date
2013-08-21 00:03:24 -0700 (Wed, 21 Aug 2013)

Log Message

<https://webkit.org/b/119836> [GTK] ChromeClient::paint is susceptible to system time changes

Reviewed by Martin Robinson.

Instead of using WTF::currentTime() as the value of the last display occurrence,
WTF::monotonicallyIncreasingTime() should be used. The latter is not affected by
the changes is the system's time, which can cause a halt in the display updating.

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::paint):

Modified Paths

Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (154379 => 154380)


--- trunk/Source/WebKit/gtk/ChangeLog	2013-08-21 06:06:10 UTC (rev 154379)
+++ trunk/Source/WebKit/gtk/ChangeLog	2013-08-21 07:03:24 UTC (rev 154380)
@@ -1,3 +1,16 @@
+2013-08-21  Zan Dobersek  <[email protected]>
+
+        <https://webkit.org/b/119836> [GTK] ChromeClient::paint is susceptible to system time changes
+
+        Reviewed by Martin Robinson.
+
+        Instead of using WTF::currentTime() as the value of the last display occurrence,
+        WTF::monotonicallyIncreasingTime() should be used. The latter is not affected by
+        the changes is the system's time, which can cause a halt in the display updating.
+
+        * WebCoreSupport/ChromeClientGtk.cpp:
+        (WebKit::ChromeClient::paint):
+
 2013-08-19  Pratik Solanki  <[email protected]>
 
         <https://webkit.org/b/119918> Frame::selection() should return a reference

Modified: trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp (154379 => 154380)


--- trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp	2013-08-21 06:06:10 UTC (rev 154379)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp	2013-08-21 07:03:24 UTC (rev 154380)
@@ -588,7 +588,7 @@
 void ChromeClient::paint(WebCore::Timer<ChromeClient>*)
 {
     static const double minimumFrameInterval = 1.0 / 60.0; // No more than 60 frames a second.
-    double timeSinceLastDisplay = currentTime() - m_lastDisplayTime;
+    double timeSinceLastDisplay = monotonicallyIncreasingTime() - m_lastDisplayTime;
     double timeUntilNextDisplay = minimumFrameInterval - timeSinceLastDisplay;
 
     if (timeUntilNextDisplay > 0 && !m_forcePaint) {
@@ -617,7 +617,7 @@
     gtk_widget_queue_draw_area(GTK_WIDGET(m_webView), rect.x(), rect.y(), rect.width(), rect.height());
 
     m_dirtyRegion = Region();
-    m_lastDisplayTime = currentTime();
+    m_lastDisplayTime = monotonicallyIncreasingTime();
     m_repaintSoonSourceId = 0;
 
     // We update the IM context window location here, because we want it to be
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to