Title: [154410] trunk/LayoutTests
- Revision
- 154410
- Author
- [email protected]
- Date
- 2013-08-21 13:58:35 -0700 (Wed, 21 Aug 2013)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=111650
REGRESSION (r143931): set-cookie-on-redirect.html still breaking subsequent tests
Reviewed by Brady Eidson.
Work around <rdar://problem/10080130> by making the cookie persistent, session
cookies are deleted in a way that confuses some code paths in CFNetwork.
I'll unskip tests later, with another cookie reliability fix.
* http/tests/cookies/resources/set-cookie-on-redirect.php:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (154409 => 154410)
--- trunk/LayoutTests/ChangeLog 2013-08-21 20:54:20 UTC (rev 154409)
+++ trunk/LayoutTests/ChangeLog 2013-08-21 20:58:35 UTC (rev 154410)
@@ -1,3 +1,17 @@
+2013-08-21 Alexey Proskuryakov <[email protected]>
+
+ https://bugs.webkit.org/show_bug.cgi?id=111650
+ REGRESSION (r143931): set-cookie-on-redirect.html still breaking subsequent tests
+
+ Reviewed by Brady Eidson.
+
+ Work around <rdar://problem/10080130> by making the cookie persistent, session
+ cookies are deleted in a way that confuses some code paths in CFNetwork.
+
+ I'll unskip tests later, with another cookie reliability fix.
+
+ * http/tests/cookies/resources/set-cookie-on-redirect.php:
+
2013-08-21 Filip Pizlo <[email protected]>
Assertion failure in JSC::SlotVisitor::copyLater when marking JSDataView
Modified: trunk/LayoutTests/http/tests/cookies/resources/set-cookie-on-redirect.php (154409 => 154410)
--- trunk/LayoutTests/http/tests/cookies/resources/set-cookie-on-redirect.php 2013-08-21 20:54:20 UTC (rev 154409)
+++ trunk/LayoutTests/http/tests/cookies/resources/set-cookie-on-redirect.php 2013-08-21 20:58:35 UTC (rev 154410)
@@ -4,13 +4,13 @@
header('Location: http://localhost:8000/cookies/resources/set-cookie-on-redirect.php?step=2');
} else if ($_GET['step'] == 2) {
header("HTTP/1.0 302 Found");
- setcookie("test_cookie", "1");
+ setcookie("test_cookie", "1", time() + 86400);
header('Location: http://localhost:8000/cookies/resources/set-cookie-on-redirect.php?step=3');
} else if ($_GET['step'] == 3) {
header("HTTP/1.0 200 OK");
if (isset($_COOKIE['test_cookie'])) {
/* Clear cookie in order not to affect other tests. */
- setcookie("test_cookie", "", time() - 1);
+ setcookie("test_cookie", "", time() - 86400);
echo "PASSED: Cookie successfully set\n";
} else {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
