Title: [154460] trunk
- Revision
- 154460
- Author
- [email protected]
- Date
- 2013-08-22 14:24:10 -0700 (Thu, 22 Aug 2013)
Log Message
Error.stack should not be enumerable
https://bugs.webkit.org/show_bug.cgi?id=120171
Reviewed by Oliver Hunt.
Breaks ECMA tests.
Source/_javascript_Core:
* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::finishCreation):
- None -> DontEnum
LayoutTests:
* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
- Update test expectations.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (154459 => 154460)
--- trunk/LayoutTests/ChangeLog 2013-08-22 20:35:09 UTC (rev 154459)
+++ trunk/LayoutTests/ChangeLog 2013-08-22 21:24:10 UTC (rev 154460)
@@ -1,5 +1,18 @@
-2013-08-22 Anton Obzhirov <[email protected]>
+2013-08-22 Gavin Barraclough <[email protected]>
+ Error.stack should not be enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=120171
+
+ Reviewed by Oliver Hunt.
+
+ Breaks ECMA tests.
+
+ * fast/js/exception-properties-expected.txt:
+ * fast/js/script-tests/exception-properties.js:
+ - Update test expectations.
+2
+013-08-22 Anton Obzhirov <[email protected]>
+
[CSSRegions] Min-width and max-width for a region should support values other than length
https://bugs.webkit.org/show_bug.cgi?id=115248
Modified: trunk/LayoutTests/fast/js/exception-properties-expected.txt (154459 => 154460)
--- trunk/LayoutTests/fast/js/exception-properties-expected.txt 2013-08-22 20:35:09 UTC (rev 154459)
+++ trunk/LayoutTests/fast/js/exception-properties-expected.txt 2013-08-22 21:24:10 UTC (rev 154460)
@@ -3,7 +3,7 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS enumerableProperties(error) is ["stack"]
+PASS enumerableProperties(error) is []
PASS enumerableProperties(nativeError) is ["stack", "line", "sourceURL"]
PASS Object.getPrototypeOf(nativeError).name is "RangeError"
PASS Object.getPrototypeOf(nativeError).message is ""
Modified: trunk/LayoutTests/fast/js/script-tests/exception-properties.js (154459 => 154460)
--- trunk/LayoutTests/fast/js/script-tests/exception-properties.js 2013-08-22 20:35:09 UTC (rev 154459)
+++ trunk/LayoutTests/fast/js/script-tests/exception-properties.js 2013-08-22 21:24:10 UTC (rev 154460)
@@ -15,7 +15,7 @@
var nativeError = rangeError;
var error = new Error("message");
- shouldBe('enumerableProperties(error)', '["stack"]');
+ shouldBe('enumerableProperties(error)', '[]');
shouldBe('enumerableProperties(nativeError)', '["stack", "line", "sourceURL"]');
shouldBe('Object.getPrototypeOf(nativeError).name', '"RangeError"');
Modified: trunk/Source/_javascript_Core/ChangeLog (154459 => 154460)
--- trunk/Source/_javascript_Core/ChangeLog 2013-08-22 20:35:09 UTC (rev 154459)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-08-22 21:24:10 UTC (rev 154460)
@@ -1,3 +1,16 @@
+2013-08-22 Gavin Barraclough <[email protected]>
+
+ Error.stack should not be enumerable
+ https://bugs.webkit.org/show_bug.cgi?id=120171
+
+ Reviewed by Oliver Hunt.
+
+ Breaks ECMA tests.
+
+ * runtime/ErrorInstance.cpp:
+ (JSC::ErrorInstance::finishCreation):
+ - None -> DontEnum
+
2013-08-21 Gavin Barraclough <[email protected]>
https://bugs.webkit.org/show_bug.cgi?id=120128
Modified: trunk/Source/_javascript_Core/runtime/ErrorInstance.cpp (154459 => 154460)
--- trunk/Source/_javascript_Core/runtime/ErrorInstance.cpp 2013-08-22 20:35:09 UTC (rev 154459)
+++ trunk/Source/_javascript_Core/runtime/ErrorInstance.cpp 2013-08-22 21:24:10 UTC (rev 154460)
@@ -44,7 +44,7 @@
putDirect(vm, vm.propertyNames->message, jsString(&vm, message), DontEnum);
if (!stackTrace.isEmpty())
- putDirect(vm, vm.propertyNames->stack, vm.interpreter->stackTraceAsString(vm.topCallFrame, stackTrace), None);
+ putDirect(vm, vm.propertyNames->stack, vm.interpreter->stackTraceAsString(vm.topCallFrame, stackTrace), DontEnum);
}
} // namespace JSC
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
