Title: [154464] trunk/Source/WebCore
- Revision
- 154464
- Author
- [email protected]
- Date
- 2013-08-22 15:41:55 -0700 (Thu, 22 Aug 2013)
Log Message
Unavailable plug-in indicator text is one pixel too low
https://bugs.webkit.org/show_bug.cgi?id=120177
<rdar://problem/14811951>
Reviewed by Kevin Decker.
Move the unavailable plug-in indicator text up one pixel.
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintReplaced):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (154463 => 154464)
--- trunk/Source/WebCore/ChangeLog 2013-08-22 22:41:43 UTC (rev 154463)
+++ trunk/Source/WebCore/ChangeLog 2013-08-22 22:41:55 UTC (rev 154464)
@@ -1,3 +1,16 @@
+2013-08-22 Tim Horton <[email protected]>
+
+ Unavailable plug-in indicator text is one pixel too low
+ https://bugs.webkit.org/show_bug.cgi?id=120177
+ <rdar://problem/14811951>
+
+ Reviewed by Kevin Decker.
+
+ Move the unavailable plug-in indicator text up one pixel.
+
+ * rendering/RenderEmbeddedObject.cpp:
+ (WebCore::RenderEmbeddedObject::paintReplaced):
+
2013-08-22 Christophe Dumez <[email protected]>
[SVG2] Merge SVGStyledElement and SVGElement
Modified: trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp (154463 => 154464)
--- trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp 2013-08-22 22:41:43 UTC (rev 154463)
+++ trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp 2013-08-22 22:41:55 UTC (rev 154464)
@@ -70,6 +70,7 @@
static const float replacementTextRoundedRectLeftTextMargin = 10;
static const float replacementTextRoundedRectRightTextMargin = 10;
static const float replacementTextRoundedRectRightTextMarginWithArrow = 5;
+static const float replacementTextRoundedRectTopTextMargin = -1;
static const float replacementTextRoundedRectRadius = 11;
static const float replacementArrowLeftMargin = -4;
static const float replacementArrowPadding = 4;
@@ -307,7 +308,7 @@
const FontMetrics& fontMetrics = font.fontMetrics();
float labelX = roundf(replacementTextRect.location().x() + replacementTextRoundedRectLeftTextMargin);
- float labelY = roundf(replacementTextRect.location().y() + (replacementTextRect.size().height() - fontMetrics.height()) / 2 + fontMetrics.ascent());
+ float labelY = roundf(replacementTextRect.location().y() + (replacementTextRect.size().height() - fontMetrics.height()) / 2 + fontMetrics.ascent() + replacementTextRoundedRectTopTextMargin);
context->setFillColor(replacementTextColor(), style()->colorSpace());
context->drawBidiText(font, run, FloatPoint(labelX, labelY));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
