Title: [154476] trunk
- Revision
- 154476
- Author
- [email protected]
- Date
- 2013-08-23 01:28:44 -0700 (Fri, 23 Aug 2013)
Log Message
Missing null-check in HTMLFormElement::rendererIsNeeded()
https://bugs.webkit.org/show_bug.cgi?id=120159
Reviewed by Ryosuke Niwa.
Source/WebCore:
Null-check parentRenderer in HTMLFormElement::rendererIsNeeded()
and early return.
Test: fast/forms/missing-parentrenderer-crash.html
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
LayoutTests:
Test for the handling of null parentRederer.
* fast/forms/missing-parentrenderer-crash-expected.txt: Added.
* fast/forms/missing-parentrenderer-crash.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (154475 => 154476)
--- trunk/LayoutTests/ChangeLog 2013-08-23 07:19:17 UTC (rev 154475)
+++ trunk/LayoutTests/ChangeLog 2013-08-23 08:28:44 UTC (rev 154476)
@@ -1,3 +1,15 @@
+2013-08-23 Renata Hodovan <[email protected]>
+
+ Missing null-check in HTMLFormElement::rendererIsNeeded()
+ https://bugs.webkit.org/show_bug.cgi?id=120159
+
+ Reviewed by Ryosuke Niwa.
+
+ Test for the handling of null parentRederer.
+
+ * fast/forms/missing-parentrenderer-crash-expected.txt: Added.
+ * fast/forms/missing-parentrenderer-crash.html: Added.
+
2013-08-23 Zalan Bujtas <[email protected]>
MathML: ASSERTION FAILED: !isPreferredLogicalHeightDirty() in RenderMathMLBlock::preferredLogicalHeight() const
Added: trunk/LayoutTests/fast/forms/missing-parentrenderer-crash-expected.txt (0 => 154476)
--- trunk/LayoutTests/fast/forms/missing-parentrenderer-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/missing-parentrenderer-crash-expected.txt 2013-08-23 08:28:44 UTC (rev 154476)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.
Added: trunk/LayoutTests/fast/forms/missing-parentrenderer-crash.html (0 => 154476)
--- trunk/LayoutTests/fast/forms/missing-parentrenderer-crash.html (rev 0)
+++ trunk/LayoutTests/fast/forms/missing-parentrenderer-crash.html 2013-08-23 08:28:44 UTC (rev 154476)
@@ -0,0 +1,12 @@
+<html>
+ <blockquote style="-webkit-flow-from: thread;"/>
+ <table/>
+ <form/>
+
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+
+ document.body.innerHTML = "PASS. WebKit didn't crash.";
+ </script>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (154475 => 154476)
--- trunk/Source/WebCore/ChangeLog 2013-08-23 07:19:17 UTC (rev 154475)
+++ trunk/Source/WebCore/ChangeLog 2013-08-23 08:28:44 UTC (rev 154476)
@@ -1,3 +1,18 @@
+2013-08-23 Renata Hodovan <[email protected]>
+
+ Missing null-check in HTMLFormElement::rendererIsNeeded()
+ https://bugs.webkit.org/show_bug.cgi?id=120159
+
+ Reviewed by Ryosuke Niwa.
+
+ Null-check parentRenderer in HTMLFormElement::rendererIsNeeded()
+ and early return.
+
+ Test: fast/forms/missing-parentrenderer-crash.html
+
+ * html/HTMLFormElement.cpp:
+ (WebCore::HTMLFormElement::rendererIsNeeded):
+
2013-08-23 Zalan Bujtas <[email protected]>
MathML: ASSERTION FAILED: !isPreferredLogicalHeightDirty() in RenderMathMLBlock::preferredLogicalHeight() const
Modified: trunk/Source/WebCore/html/HTMLFormElement.cpp (154475 => 154476)
--- trunk/Source/WebCore/html/HTMLFormElement.cpp 2013-08-23 07:19:17 UTC (rev 154475)
+++ trunk/Source/WebCore/html/HTMLFormElement.cpp 2013-08-23 08:28:44 UTC (rev 154476)
@@ -101,6 +101,10 @@
ContainerNode* node = parentNode();
RenderObject* parentRenderer = node->renderer();
+
+ if (!parentRenderer)
+ return false;
+
// FIXME: Shouldn't we also check for table caption (see |formIsTablePart| below).
bool parentIsTableElementPart = (parentRenderer->isTable() && isHTMLTableElement(node))
|| (parentRenderer->isTableRow() && node->hasTagName(trTag))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
