Title: [154529] trunk
- Revision
- 154529
- Author
- [email protected]
- Date
- 2013-08-23 16:00:38 -0700 (Fri, 23 Aug 2013)
Log Message
REGRESSION (r150516): Media controls are messed up on right-to-left webpages
https://bugs.webkit.org/show_bug.cgi?id=120234
Reviewed by Dan Bernstein.
Source/WebCore:
Test: media/video-rtl.html
Make the media control panel explicitly direction:ltr. The captions menu and captions
display are unaffected, so rtl content will continue to appear rtl there.
* css/mediaControls.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
LayoutTests:
* media/video-rtl-expected.html: Added.
* media/video-rtl.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (154528 => 154529)
--- trunk/LayoutTests/ChangeLog 2013-08-23 22:57:07 UTC (rev 154528)
+++ trunk/LayoutTests/ChangeLog 2013-08-23 23:00:38 UTC (rev 154529)
@@ -1,3 +1,13 @@
+2013-08-23 Jer Noble <[email protected]>
+
+ REGRESSION (r150516): Media controls are messed up on right-to-left webpages
+ https://bugs.webkit.org/show_bug.cgi?id=120234
+
+ Reviewed by Dan Bernstein.
+
+ * media/video-rtl-expected.html: Added.
+ * media/video-rtl.html: Added.
+
2013-08-23 Eric Carlson <[email protected]>
[Mac] some track language tags are not recognized
Added: trunk/LayoutTests/media/video-rtl-expected.html (0 => 154529)
--- trunk/LayoutTests/media/video-rtl-expected.html (rev 0)
+++ trunk/LayoutTests/media/video-rtl-expected.html 2013-08-23 23:00:38 UTC (rev 154529)
@@ -0,0 +1,18 @@
+<html>
+<head>
+ <script src=""
+ <script>
+ var requirePixelDump = true;
+
+ function start() {
+ findMediaElement();
+ video.src = "" 'content/test');
+ video.addEventListener('canplaythrough', endTest, false);
+ }
+ </script>
+ <script src=""
+</head>
+<body _onload_="start()">
+ <video controls></video>
+</body>
+</html>
\ No newline at end of file
Added: trunk/LayoutTests/media/video-rtl.html (0 => 154529)
--- trunk/LayoutTests/media/video-rtl.html (rev 0)
+++ trunk/LayoutTests/media/video-rtl.html 2013-08-23 23:00:38 UTC (rev 154529)
@@ -0,0 +1,21 @@
+<html>
+<head>
+ <script src=""
+ <script>
+ var requirePixelDump = true;
+
+ function start() {
+ findMediaElement();
+ video.src = "" 'content/test');
+ video.addEventListener('canplaythrough', endTest, false);
+ }
+ </script>
+ <script src=""
+ <style>
+ video { direction: rtl; }
+ </style>
+</head>
+<body _onload_="start()">
+ <video controls></video>
+</body>
+</html>
\ No newline at end of file
Modified: trunk/Source/WebCore/ChangeLog (154528 => 154529)
--- trunk/Source/WebCore/ChangeLog 2013-08-23 22:57:07 UTC (rev 154528)
+++ trunk/Source/WebCore/ChangeLog 2013-08-23 23:00:38 UTC (rev 154529)
@@ -1,3 +1,18 @@
+2013-08-23 Jer Noble <[email protected]>
+
+ REGRESSION (r150516): Media controls are messed up on right-to-left webpages
+ https://bugs.webkit.org/show_bug.cgi?id=120234
+
+ Reviewed by Dan Bernstein.
+
+ Test: media/video-rtl.html
+
+ Make the media control panel explicitly direction:ltr. The captions menu and captions
+ display are unaffected, so rtl content will continue to appear rtl there.
+
+ * css/mediaControls.css:
+ (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
+
2013-08-23 Beth Dakin <[email protected]>
REGRESSION (r132545): Some PDFs generated by WebKit are blank when viewed in
Modified: trunk/Source/WebCore/css/mediaControls.css (154528 => 154529)
--- trunk/Source/WebCore/css/mediaControls.css 2013-08-23 22:57:07 UTC (rev 154528)
+++ trunk/Source/WebCore/css/mediaControls.css 2013-08-23 23:00:38 UTC (rev 154529)
@@ -45,6 +45,7 @@
audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel {
display: -webkit-flex;
+ direction: ltr;
-webkit-flex-direction: row;
-webkit-align-items: center;
-webkit-user-select: none;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
