Title: [154623] trunk/Source/WebCore
- Revision
- 154623
- Author
- [email protected]
- Date
- 2013-08-26 11:41:26 -0700 (Mon, 26 Aug 2013)
Log Message
Prettify generated build guards in HTMLElementFactory.cpp
https://bugs.webkit.org/show_bug.cgi?id=120310
Reviewed by Darin Adler.
Build guards should wrap the constructor definitions without empty lines between
the guards and the constructor code. Similarly, build guards for addTag calls
shouldn't put an empty line after the build guard closure.
* dom/make_names.pl:
(printConstructorInterior):
(printConstructors):
(printFunctionInits):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (154622 => 154623)
--- trunk/Source/WebCore/ChangeLog 2013-08-26 18:31:24 UTC (rev 154622)
+++ trunk/Source/WebCore/ChangeLog 2013-08-26 18:41:26 UTC (rev 154623)
@@ -1,3 +1,19 @@
+2013-08-26 Zan Dobersek <[email protected]>
+
+ Prettify generated build guards in HTMLElementFactory.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=120310
+
+ Reviewed by Darin Adler.
+
+ Build guards should wrap the constructor definitions without empty lines between
+ the guards and the constructor code. Similarly, build guards for addTag calls
+ shouldn't put an empty line after the build guard closure.
+
+ * dom/make_names.pl:
+ (printConstructorInterior):
+ (printConstructors):
+ (printFunctionInits):
+
2013-08-26 Robert Hogan <[email protected]>
Avoid painting every non-edge collapsed border twice over
Modified: trunk/Source/WebCore/dom/make_names.pl (154622 => 154623)
--- trunk/Source/WebCore/dom/make_names.pl 2013-08-26 18:31:24 UTC (rev 154622)
+++ trunk/Source/WebCore/dom/make_names.pl 2013-08-26 18:41:26 UTC (rev 154623)
@@ -424,7 +424,7 @@
print F " return ${interfaceName}::create($constructorTagName, document";
print F ", formElement" if $enabledTags{$tagName}{constructorNeedsFormElement};
print F ", createdByParser" if $enabledTags{$tagName}{constructorNeedsCreatedByParser};
- print F ");\n}\n\n";
+ print F ");\n}\n";
}
sub printConstructors
@@ -450,7 +450,7 @@
my $conditional = $enabledTags{$tagName}{conditional};
if ($conditional) {
my $conditionalString = "ENABLE(" . join(") && ENABLE(", split(/&/, $conditional)) . ")";
- print F "#if ${conditionalString}\n\n";
+ print F "#if ${conditionalString}\n";
}
printConstructorSignature($F, $tagName, $tagConstructorMap{$tagName}, "tagName");
@@ -459,6 +459,8 @@
if ($conditional) {
print F "#endif\n";
}
+
+ print F "\n";
}
# Mapped tag name uses a special wrapper to keep their prefix and namespaceURI while using the mapped localname.
@@ -492,7 +494,7 @@
}
if ($conditional) {
- print F "#endif\n\n";
+ print F "#endif\n";
}
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
