Title: [154644] trunk
- Revision
- 154644
- Author
- [email protected]
- Date
- 2013-08-26 14:53:05 -0700 (Mon, 26 Aug 2013)
Log Message
Lonely stop crashes
https://bugs.webkit.org/show_bug.cgi?id=87964
Reviewed by Darin Adler.
Source/WebCore:
Provide a nodeAtFloatPoint implementation for RenderSVGGradientStop to avoid hitting the assert in RenderObject::nodeAtFloatPoint.
Test: svg/custom/stop-crash-hittest.svg
* rendering/svg/RenderSVGGradientStop.h:
LayoutTests:
Add testcase by taking stop-crash.svg and adding hittest instructions.
* svg/custom/stop-crash-hittest-expected.txt: Added.
* svg/custom/stop-crash-hittest.svg: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (154643 => 154644)
--- trunk/LayoutTests/ChangeLog 2013-08-26 21:50:32 UTC (rev 154643)
+++ trunk/LayoutTests/ChangeLog 2013-08-26 21:53:05 UTC (rev 154644)
@@ -1,3 +1,15 @@
+2013-08-26 Rob Buis <[email protected]>
+
+ Lonely stop crashes
+ https://bugs.webkit.org/show_bug.cgi?id=87964
+
+ Reviewed by Darin Adler.
+
+ Add testcase by taking stop-crash.svg and adding hittest instructions.
+
+ * svg/custom/stop-crash-hittest-expected.txt: Added.
+ * svg/custom/stop-crash-hittest.svg: Added.
+
2013-08-26 Bem Jones-Bey <[email protected]>
Optimize FloatIntervalSearchAdapter::collectIfNeeded
Added: trunk/LayoutTests/svg/custom/stop-crash-hittest-expected.txt (0 => 154644)
--- trunk/LayoutTests/svg/custom/stop-crash-hittest-expected.txt (rev 0)
+++ trunk/LayoutTests/svg/custom/stop-crash-hittest-expected.txt 2013-08-26 21:53:05 UTC (rev 154644)
@@ -0,0 +1 @@
+PASS -- if this test doesn't crash it passes.
Added: trunk/LayoutTests/svg/custom/stop-crash-hittest.svg (0 => 154644)
--- trunk/LayoutTests/svg/custom/stop-crash-hittest.svg (rev 0)
+++ trunk/LayoutTests/svg/custom/stop-crash-hittest.svg 2013-08-26 21:53:05 UTC (rev 154644)
@@ -0,0 +1,13 @@
+<svg xmlns="http://www.w3.org/2000/svg">
+ <stop/>
+ <script>
+ if (window.testRunner)
+ testRunner.dumpAsText();
+ if (window.eventSender) {
+ eventSender.mouseMoveTo(200, 200);
+ eventSender.mouseDown();
+ eventSender.mouseUp();
+ }
+ </script>
+ <text x="10" y="25">PASS -- if this test doesn't crash it passes.</text>
+</svg>
Modified: trunk/Source/WebCore/ChangeLog (154643 => 154644)
--- trunk/Source/WebCore/ChangeLog 2013-08-26 21:50:32 UTC (rev 154643)
+++ trunk/Source/WebCore/ChangeLog 2013-08-26 21:53:05 UTC (rev 154644)
@@ -1,3 +1,16 @@
+2013-08-26 Rob Buis <[email protected]>
+
+ Lonely stop crashes
+ https://bugs.webkit.org/show_bug.cgi?id=87964
+
+ Reviewed by Darin Adler.
+
+ Provide a nodeAtFloatPoint implementation for RenderSVGGradientStop to avoid hitting the assert in RenderObject::nodeAtFloatPoint.
+
+ Test: svg/custom/stop-crash-hittest.svg
+
+ * rendering/svg/RenderSVGGradientStop.h:
+
2013-08-26 Sam Weinig <[email protected]>
Editor::spellChecker() should return a reference
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.h (154643 => 154644)
--- trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.h 2013-08-26 21:50:32 UTC (rev 154643)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGGradientStop.h 2013-08-26 21:53:05 UTC (rev 154644)
@@ -47,6 +47,7 @@
virtual FloatRect objectBoundingBox() const { return FloatRect(); }
virtual FloatRect strokeBoundingBox() const { return FloatRect(); }
virtual FloatRect repaintRectInLocalCoordinates() const { return FloatRect(); }
+ virtual bool nodeAtFloatPoint(const HitTestRequest&, HitTestResult&, const FloatPoint&, HitTestAction) OVERRIDE { return false; }
protected:
virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
